migrate Strip Hit Efficiency HitEff class to use esconsumes #31756

mmusich · 2020-10-12T14:24:13Z

PR description:

Title says it all. Part of #31061

PR validation:

Run the unit tests in CalibTracker/SiStripCommon

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed.

cmsbuild · 2020-10-12T14:24:35Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-12T14:30:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31756/18981

This PR adds an extra 24KB to repository

cmsbuild · 2020-10-12T14:31:01Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripHitEfficiency

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2020-10-12T14:32:03Z

@cmsbuild, please test

mmusich · 2020-10-12T14:32:10Z

@makortel, this should solve:

I found errors in the following unit tests:

---> test testCalibTrackerSiStripCommon had ERRORS

in #31746 (comment)

cmsbuild · 2020-10-12T14:32:26Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-12-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9892/console Started: 2020/10/12 16:32

makortel · 2020-10-12T14:40:14Z

Thanks @mmusich!

cmsbuild · 2020-10-12T15:43:17Z

+1
Tested at: fa17719
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8650d3/9892/summary.html
CMSSW: CMSSW_11_2_X_2020-10-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-12T15:43:19Z

Comparison job queued.

cmsbuild · 2020-10-12T17:10:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8650d3/9892/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542196
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

CalibTracker/SiStripHitEfficiency/src/HitEff.cc

cmsbuild · 2020-10-13T13:27:23Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-13T13:31:31Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8650d3/9904/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542202
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cmsbuild · 2020-10-13T13:32:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31756/19009

This PR adds an extra 24KB to repository

cmsbuild · 2020-10-13T13:32:23Z

Pull request #31756 was updated. @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please check and sign again.

mmusich · 2020-10-13T13:34:40Z

@cmsbuild, please test

cmsbuild · 2020-10-13T13:35:04Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-13-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9913/console Started: 2020/10/13 15:46

cmsbuild · 2020-10-13T15:02:10Z

+1
Tested at: 0c3fe80
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8650d3/9913/summary.html
CMSSW: CMSSW_11_2_X_2020-10-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-13T15:02:13Z

Comparison job queued.

cmsbuild · 2020-10-13T16:19:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8650d3/9913/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2543692
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2543669
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

yuanchao · 2020-10-14T10:14:21Z

+1

cmsbuild · 2020-10-14T10:14:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-10-14T14:34:46Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Oct 12, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Oct 12, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 12, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 12, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 12, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 12, 2020

Dr15Jones reviewed Oct 12, 2020

View reviewed changes

CalibTracker/SiStripHitEfficiency/src/HitEff.cc Outdated Show resolved Hide resolved

mmusich force-pushed the migrateESConsumesHitEff branch from fa17719 to ab9b012 Compare October 13, 2020 08:10

cmsbuild removed code-checks-approved comparison-available tests-approved labels Oct 13, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 13, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 13, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 13, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 13, 2020

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Oct 14, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 14, 2020

cmsbuild merged commit 70ebca1 into cms-sw:master Oct 14, 2020

This was referenced Oct 15, 2020

Removed use of boost::any in edmNew::DetSetVector #31792

Merged

Add ParticleNetAK4 to JME custom NanoAOD #31714

Merged

pieterdavid mentioned this pull request Oct 16, 2020

esConsumes migration for EDModules in SiStrip packages, part 1 #31826

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate Strip Hit Efficiency HitEff class to use esconsumes #31756

migrate Strip Hit Efficiency HitEff class to use esconsumes #31756

mmusich commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

mmusich commented Oct 12, 2020

mmusich commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 •

edited

Loading

makortel commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

mmusich commented Oct 13, 2020

cmsbuild commented Oct 13, 2020 •

edited

Loading

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

yuanchao commented Oct 14, 2020

cmsbuild commented Oct 14, 2020

silviodonato commented Oct 14, 2020

migrate Strip Hit Efficiency HitEff class to use esconsumes #31756

migrate Strip Hit Efficiency HitEff class to use esconsumes #31756

Conversation

mmusich commented Oct 12, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

mmusich commented Oct 12, 2020

mmusich commented Oct 12, 2020

cmsbuild commented Oct 12, 2020 • edited Loading

makortel commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 12, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

mmusich commented Oct 13, 2020

cmsbuild commented Oct 13, 2020 • edited Loading

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

cmsbuild commented Oct 13, 2020

yuanchao commented Oct 14, 2020

cmsbuild commented Oct 14, 2020

silviodonato commented Oct 14, 2020

cmsbuild commented Oct 12, 2020 •

edited

Loading

cmsbuild commented Oct 13, 2020 •

edited

Loading