Pr 111 x Displaced muon in BMTF and uGMT ( unpacker/emulator/packer) #31679
Conversation
The BMTF with the Kalman filter sends inverted track addresses, the uGMT cancel-out unit has been adapted for this. In this commit it has also been configured to use the new mode and pick barrel muons from the KBMTF collection.
The original field with track addresses was filled with incorrect or incomplete values for most TFs. Using static function from RegionalMuonRawDigiTranslator that I factored out in order to generate the raw track address.
May make the interface to get them more clear.
This makes us a bit more consistent with the other fields.
Co-Authored-By: panoskatsoulis <[email protected]>
This should be configured based on eras in the future.
In the MuonUnpacker the wrong overloaded function was being called, this is fixed now. In the process I also rewrote my earlier attempt, it should be more readable now.
Also add displacement information to uGMT intermediate muons and light refactoring for clarity.
Packs correctly for Run-2 2016, Run-2 from 2017 (w/ extrapolated coordiantes), and Run-3
The original field with track addresses was filled with incorrect or incomplete values for most TFs. Using static function from RegionalMuonRawDigiTranslator that I factored out in order to generate the raw track address.
Includes configuration of packer by Era. Modifications still needed for the BMTF setup to make use of this.
Not done nicely, should be cleaned up.
|
+1 |
|
backport of #31608 |
|
Comparison is ready Comparison Summary:
|
|
@jfernan2 |
| //debug up to here | ||
| */ | ||
| //debug from here | ||
| std::cout << "block id : " << block.header().getID() << std::endl; |
There was a problem hiding this comment.
despite the code is commented and it was already there, are couts allowed?
|
@rekovic since this PR is needed for next MWGR, we are testing it at P5 in DQM Playback |
|
The test at P5 went fine, I am OK with the PR, I am not sure if the coding rules allow the couts even if commented |
|
Hi @jfernan2, since this is a backport I suppose it would be best to keep it as is, but I could make a new PR to remove those lines. Would that be acceptable for you? Cheers, |
|
Sure |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
11_2_X: L1T Displaced muons: Pt from unconstrainedVtx
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
backport of #31608
Before submitting your pull requests, make sure you followed this checklist: