[DD4hep] Filtered View Performance Step 1

[ianna]

PR description:

• Tested with PR DD4hep: Introduces functional Tracker navigation + DetIds building #31573
• 10x speed up of a Geometry/TrackerNumberingBuilder/test/trackerModuleNumberingDD4hep_cfg.py test:

<  - Min event:   63.58
<  - Max event:   63.58
<  - Avg event:   63.58
<  - Total loop:  63.5812
<  - Total init:  4.48886
<  - Total job:   68.072
---
>  - Min event:   711.722
>  - Max event:   711.722
>  - Avg event:   711.722
>  - Total loop:  711.723
>  - Total init:  4.61527
>  - Total job:   716.342
55657c55657
<  Event Throughput: 0.0157279 ev/s
---
>  Event Throughput: 0.00140504 ev/s
55659,55660c55659,55660
<  - Total loop:  63.4066
<  - Total init:  2.38696
---
>  - Total loop:  711.334
>  - Total init:  2.43249
55662c55662
<  - Total job:   65.7951
---
>  - Total job:   713.769

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31630/18701

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/src/DDFilteredView.cc modified in PR(s): DD4hep: Introduces functional Tracker navigation + DetIds building #31573

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9665/console Started: 2020/09/30 16:53

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 4bffb5a

CMSSW: CMSSW_11_2_X_2020-09-30-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d5a31/9665/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

• Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31630/18721

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #31630 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

[ianna]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-01-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9680/console Started: 2020/10/01 15:32

[cmsbuild]

+1
Tested at: 4b2ea25
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d5a31/9680/summary.html
CMSSW: CMSSW_11_2_X_2020-10-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d5a31/9680/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2542225
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2542199
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[ianna]

@silviodonato - would it be possible to integrate it in the 11:00 o'clock IB? Thanks

[silviodonato]

+1