PPS: relative alignment #31629

jan-kaspar · 2020-09-30T13:28:51Z

PR description:

Following the discussion in the AlCaDB meeting on 28 Sep this PR contains implementation of the "relative" alignment of PPS. Integration of the "global" part is foreseen soon.

For more details please refer to the README file in "CalibPPS/AlignmentRelative".

PR validation:

Various tests are included in the test directory.

cmsbuild · 2020-09-30T13:29:15Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-30T13:36:40Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18699

This PR adds an extra 248KB to repository
Found files with invalid states:
- Alignment/PPSTrackBased/test/test_with_mc/iterations/template_cfg.py:
  - Added: 8a23f0b
  - Modified: dbadb61, a33b681
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/simple/cfg.py:
  - Added: 8a23f0b
  - Modified: 4146381, 4eaad7c, dbadb61, a33b681, e0f7b7d, 43b052b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/RP_Dist_Beam_Cent.xml:
  - Added: 8a23f0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentConstraint.h:
  - Added: 113f3a3
  - Modified: 319d1ab, 4146381, bc95cdf, 9d44705
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/iterations/run_iterations:
  - Added: 8a23f0b
  - Deleted: dbadb61
- Alignment/PPSTrackBased/src/IdealResult.cc:
  - Added: 04658df
  - Modified: 319d1ab, 4146381, bc95cdf, a33b681, 8f9c972, 3abb8f7, fd58ad1
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/python/ppsStraightTrackAligner_cfi.py:
  - Added: 113f3a3
  - Modified: d5b4fc3, 5ae441e, b42a163, 4b9abab, a33b681, 09db248, 9c31d33, 43b052b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_config_sector_56:
  - Added: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/statistics/run_test:
  - Added: dbadb61
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/python/ppsFastLocalSimulation_cfi.py:
  - Added: 113f3a3
  - Modified: 56a406e
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/simple/run_test:
  - Added: dbadb61
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/AlignmentAlgorithm.cc:
  - Added: 113f3a3
  - Modified: 8f9c972
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/statistics/make_plots.asy:
  - Added: c1432de
  - Modified: aa5f053
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/BuildFile.xml:
  - Added: c1432de
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_code:
  - Added: 640b318
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_config_sector_45:
  - Added: 640b318
  - Modified: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentGeometry.h:
  - Added: 113f3a3
  - Modified: 4146381, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/LocalTrackFitter.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/template_msm_cfg.py:
  - Added: 4ce8a0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/RP_Dist_Beam_Cent.xml:
  - Added: 640b318
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentAlgorithm.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/BuildFile.xml:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/CommonMethods.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: f455e33
- Alignment/PPSTrackBased/interface/AlignmentTask.h:
  - Added: 113f3a3
  - Modified: 4146381, 5ae441e, b42a163, 4b9abab, 09db248
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/PPSFastLocalSimulation.cc:
  - Added: 113f3a3
  - Modified: 4146381, a33b681, 8f9c972, 35d5b33, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/Utilities.h:
  - Added: 113f3a3
  - Modified: 4146381, f455e33
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/SingularMode.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/IdealResult.h:
  - Added: 04658df
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/mis_alignment_s.xml:
  - Added: 8a23f0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/README.md:
  - Added: a6d8d38
  - Modified: f6e140f
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/ppsTrackBasedAligAnalRes.cc:
  - Added: c1432de
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/iterations/run_test:
  - Added: dbadb61
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/StraightTrackAlignment.cc:
  - Added: 113f3a3
  - Modified: 56a406e, 319d1ab, 4146381, d5b4fc3, f455e33, bc95cdf, 9d44705, 5ae441e, 4eaad7c, a33b681, 8f9c972, cb08aa8, 9c31d33, 35d5b33, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentResult.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/template_tba_cfg.py:
  - Added: 4ce8a0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/AlignmentGeometry.cc:
  - Added: 113f3a3
  - Modified: 319d1ab, 4146381, 8f9c972, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/run_test:
  - Added: 640b318
  - Modified: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/classes.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/classes_def.xml:
  - Added: 113f3a3
  - Modified: 5ae441e
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/mis_alignment_r.xml:
  - Added: 8a23f0b
  - Modified: 1266951
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_template.py:
  - Added: 640b318
  - Modified: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/python/ppsModifySingularModes_cfi.py:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/StraightTrackAlignment.h:
  - Added: 113f3a3
  - Modified: 4146381, d5b4fc3, 5ae441e, a33b681, 9c31d33
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/JanAlignmentAlgorithm.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/input.xml:
  - Added: 4ce8a0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/AlignmentTask.cc:
  - Added: 113f3a3
  - Modified: 56a406e, 319d1ab, 4146381, bc95cdf, 9d44705, 5ae441e, 4eaad7c, b42a163, 4b9abab, 8f9c972, e0f7b7d, 09db248, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_submit:
  - Added: 640b318
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/LocalTrackFitter.cc:
  - Added: 113f3a3
  - Modified: 4146381, 8f9c972
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/JanAlignmentAlgorithm.cc:
  - Added: 113f3a3
  - Modified: 4146381, a33b681, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/PPSModifySingularModes.cc:
  - Added: 113f3a3
  - Modified: 4146381, f455e33, 4eaad7c, 8f9c972, 4ce8a0b, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/CommonMethods.cc:
  - Added: 113f3a3
  - Modified: 319d1ab, 4146381, d5b4fc3
  - Deleted: f455e33
- Alignment/PPSTrackBased/src/Utilities.cc:
  - Added: 113f3a3
  - Modified: 4146381, f455e33, 4eaad7c, a33b681, 393af8f, 8f9c972
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/BuildFile.xml:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/HitCollection.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/LocalTrackFit.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/mis_alignment_sr.xml:
  - Added: 8a23f0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/PPSStraightTrackAligner.cc:
  - Added: 113f3a3
  - Modified: 4146381, 8f9c972, 9c31d33, 35d5b33, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/README.md:
  - Added: c1432de
  - Deleted: a6d8d38
- Alignment/PPSTrackBased/test/test_with_mc/statistics/run_multiple:
  - Added: c1432de
  - Deleted: dbadb61
- Alignment/PPSTrackBased/test/test_with_mc/statistics/template_cfg.py:
  - Added: c1432de
  - Modified: a33b681
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/run_test:
  - Added: 4ce8a0b
  - Modified: f064e2b
  - Deleted: 84c55ad

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18699/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18699/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-09-30T13:45:44Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-30T13:51:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18700

This PR adds an extra 416KB to repository
Found files with invalid states:
- Alignment/PPSTrackBased/test/test_with_mc/iterations/template_cfg.py:
  - Added: 8a23f0b
  - Modified: dbadb61, a33b681
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/simple/cfg.py:
  - Added: 8a23f0b
  - Modified: 4146381, 4eaad7c, dbadb61, a33b681, e0f7b7d, 43b052b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/RP_Dist_Beam_Cent.xml:
  - Added: 8a23f0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentConstraint.h:
  - Added: 113f3a3
  - Modified: 319d1ab, 4146381, bc95cdf, 9d44705
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/iterations/run_iterations:
  - Added: 8a23f0b
  - Deleted: dbadb61
- Alignment/PPSTrackBased/src/IdealResult.cc:
  - Added: 04658df
  - Modified: 319d1ab, 4146381, bc95cdf, a33b681, 8f9c972, 3abb8f7, fd58ad1
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/python/ppsStraightTrackAligner_cfi.py:
  - Added: 113f3a3
  - Modified: d5b4fc3, 5ae441e, b42a163, 4b9abab, a33b681, 09db248, 9c31d33, 43b052b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_config_sector_56:
  - Added: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/statistics/run_test:
  - Added: dbadb61
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/python/ppsFastLocalSimulation_cfi.py:
  - Added: 113f3a3
  - Modified: 56a406e
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/simple/run_test:
  - Added: dbadb61
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/AlignmentAlgorithm.cc:
  - Added: 113f3a3
  - Modified: 8f9c972
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/statistics/make_plots.asy:
  - Added: c1432de
  - Modified: aa5f053
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/BuildFile.xml:
  - Added: c1432de
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_code:
  - Added: 640b318
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_config_sector_45:
  - Added: 640b318
  - Modified: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentGeometry.h:
  - Added: 113f3a3
  - Modified: 4146381, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/LocalTrackFitter.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/template_msm_cfg.py:
  - Added: 4ce8a0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/RP_Dist_Beam_Cent.xml:
  - Added: 640b318
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentAlgorithm.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/BuildFile.xml:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/CommonMethods.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: f455e33
- Alignment/PPSTrackBased/interface/AlignmentTask.h:
  - Added: 113f3a3
  - Modified: 4146381, 5ae441e, b42a163, 4b9abab, 09db248
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/PPSFastLocalSimulation.cc:
  - Added: 113f3a3
  - Modified: 4146381, a33b681, 8f9c972, 35d5b33, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/Utilities.h:
  - Added: 113f3a3
  - Modified: 4146381, f455e33
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/SingularMode.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/IdealResult.h:
  - Added: 04658df
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/mis_alignment_s.xml:
  - Added: 8a23f0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/README.md:
  - Added: a6d8d38
  - Modified: f6e140f
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/ppsTrackBasedAligAnalRes.cc:
  - Added: c1432de
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/iterations/run_test:
  - Added: dbadb61
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/StraightTrackAlignment.cc:
  - Added: 113f3a3
  - Modified: 56a406e, 319d1ab, 4146381, d5b4fc3, f455e33, bc95cdf, 9d44705, 5ae441e, 4eaad7c, a33b681, 8f9c972, cb08aa8, 9c31d33, 35d5b33, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/AlignmentResult.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/template_tba_cfg.py:
  - Added: 4ce8a0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/AlignmentGeometry.cc:
  - Added: 113f3a3
  - Modified: 319d1ab, 4146381, 8f9c972, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/run_test:
  - Added: 640b318
  - Modified: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/classes.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/classes_def.xml:
  - Added: 113f3a3
  - Modified: 5ae441e
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/mis_alignment_r.xml:
  - Added: 8a23f0b
  - Modified: 1266951
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_template.py:
  - Added: 640b318
  - Modified: 8abfcb3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/python/ppsModifySingularModes_cfi.py:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/StraightTrackAlignment.h:
  - Added: 113f3a3
  - Modified: 4146381, d5b4fc3, 5ae441e, a33b681, 9c31d33
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/JanAlignmentAlgorithm.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/input.xml:
  - Added: 4ce8a0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/AlignmentTask.cc:
  - Added: 113f3a3
  - Modified: 56a406e, 319d1ab, 4146381, bc95cdf, 9d44705, 5ae441e, 4eaad7c, b42a163, 4b9abab, 8f9c972, e0f7b7d, 09db248, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_data/tb_submit:
  - Added: 640b318
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/LocalTrackFitter.cc:
  - Added: 113f3a3
  - Modified: 4146381, 8f9c972
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/JanAlignmentAlgorithm.cc:
  - Added: 113f3a3
  - Modified: 4146381, a33b681, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/PPSModifySingularModes.cc:
  - Added: 113f3a3
  - Modified: 4146381, f455e33, 4eaad7c, 8f9c972, 4ce8a0b, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/src/CommonMethods.cc:
  - Added: 113f3a3
  - Modified: 319d1ab, 4146381, d5b4fc3
  - Deleted: f455e33
- Alignment/PPSTrackBased/src/Utilities.cc:
  - Added: 113f3a3
  - Modified: 4146381, f455e33, 4eaad7c, a33b681, 393af8f, 8f9c972
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/BuildFile.xml:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/HitCollection.h:
  - Added: 113f3a3
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/interface/LocalTrackFit.h:
  - Added: 113f3a3
  - Modified: 4146381
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_with_mc/mis_alignment_sr.xml:
  - Added: 8a23f0b
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/plugins/PPSStraightTrackAligner.cc:
  - Added: 113f3a3
  - Modified: 4146381, 8f9c972, 9c31d33, 35d5b33, 418c8e8
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/README.md:
  - Added: c1432de
  - Deleted: a6d8d38
- Alignment/PPSTrackBased/test/test_with_mc/statistics/run_multiple:
  - Added: c1432de
  - Deleted: dbadb61
- Alignment/PPSTrackBased/test/test_with_mc/statistics/template_cfg.py:
  - Added: c1432de
  - Modified: a33b681
  - Deleted: 84c55ad
- Alignment/PPSTrackBased/test/test_modify_singular_modes/run_test:
  - Added: 4ce8a0b
  - Modified: f064e2b
  - Deleted: 84c55ad

cmsbuild · 2020-09-30T13:52:08Z

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

CalibPPS/AlignmentRelative
CondFormats/PPSObjects
DataFormats/CTPPSReco

The following packages do not have a category, yet:

CalibPPS/AlignmentRelative
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@perrotta, @yuanchao, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @jpata, @pohsun can you please review it and eventually sign? Thanks.
@forthommel, @rovere, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-10-01T14:04:22Z

DataFormats/CTPPSReco/src/classes_def.xml

+  <ioread sourceClass="TotemRPUVPattern" version="[2]" targetClass="TotemRPUVPattern" source="TotemRPUVPattern::ProjectionType projection" target="projection_">
+  <![CDATA[projection_ = onfile.projection;]]>
+  </ioread>


this is already in the master.
@jan-kaspar please review the commits and remove this file.
Thank you.

Thanks for pointing this out. I will address this in the next days together with the invalid-state files.

cmsbuild · 2020-10-02T12:38:56Z

The code-checks are being triggered in jenkins.

jan-kaspar · 2020-10-02T12:44:09Z

I've just pushed the code with cleaned up history.

For the change in CondFormats/PPSObjects, here's a little before-after comparison showing that no change is generated in PPS reco of Run2 data.

cmsbuild · 2020-10-02T12:45:16Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18747

This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18747/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18747/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18747/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/18747/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-11-05T08:51:53Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-11-05T08:59:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31629/19584

This PR adds an extra 152KB to repository

cmsbuild · 2020-11-05T08:59:39Z

Pull request #31629 was updated. @yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please check and sign again.

christopheralanwest · 2020-11-05T20:14:38Z

please test

cmsbuild · 2020-11-05T20:15:01Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-11-05-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10536/console Started: 2020/11/05 21:15

cmsbuild · 2020-11-05T21:35:50Z

+1
Tested at: 52ded92
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65a3e0/10536/summary.html
CMSSW: CMSSW_11_2_X_2020-11-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-05T21:35:52Z

Comparison job queued.

cmsbuild · 2020-11-05T22:51:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65a3e0/10536/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2544144
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2544115
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

yuanchao · 2020-11-06T08:59:43Z

+1

cmsbuild · 2020-11-06T09:00:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-11-06T19:59:16Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Sep 30, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending new-package-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 30, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 30, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 30, 2020

slava77 reviewed Oct 1, 2020

View reviewed changes

jan-kaspar added 2 commits October 2, 2020 14:11

Added PPS relative alignment.

3209a23

Fixed logic in getFullSensorCorrection.

629abfe

jan-kaspar force-pushed the ctpps_relative_alignment_11_2_0 branch from dfee1a6 to 629abfe Compare October 2, 2020 12:38

cmsbuild added code-checks-pending and removed code-checks-approved reconstruction-pending labels Oct 2, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending labels Nov 5, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 5, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 5, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 5, 2020

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Nov 6, 2020

silviodonato merged commit 5a81488 into cms-sw:master Nov 6, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 6, 2020

jan-kaspar deleted the ctpps_relative_alignment_11_2_0 branch December 4, 2020 10:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPS: relative alignment #31629

PPS: relative alignment #31629

jan-kaspar commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

slava77 Oct 1, 2020

jan-kaspar Oct 1, 2020

cmsbuild commented Oct 2, 2020

jan-kaspar commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

christopheralanwest commented Nov 5, 2020

cmsbuild commented Nov 5, 2020 •

edited

Loading

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

yuanchao commented Nov 6, 2020

cmsbuild commented Nov 6, 2020

silviodonato commented Nov 6, 2020

PPS: relative alignment #31629

PPS: relative alignment #31629

Conversation

jan-kaspar commented Sep 30, 2020

PR description:

PR validation:

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

cmsbuild commented Sep 30, 2020

slava77 Oct 1, 2020

Choose a reason for hiding this comment

jan-kaspar Oct 1, 2020

Choose a reason for hiding this comment

cmsbuild commented Oct 2, 2020

jan-kaspar commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

christopheralanwest commented Nov 5, 2020

cmsbuild commented Nov 5, 2020 • edited Loading

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

cmsbuild commented Nov 5, 2020

yuanchao commented Nov 6, 2020

cmsbuild commented Nov 6, 2020

silviodonato commented Nov 6, 2020

cmsbuild commented Nov 5, 2020 •

edited

Loading