Initialize vars to nullptr in HTXSRivetProducer, fix #31474

[mrodozov]

Resolves: #31474

PR description:

Fixes relvals failure (hopefully) in ASAN, see #31474

PR validation:

relvals running withot sigsegv

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc:40:13: error: use of undeclared identifier 'nullprt'; did you mean 'nullptr'? [clang-diagnostic-error]
    _HTXS = nullprt;
            ^~~~~~~
            nullptr
GeneratorInterface/RivetInterface/plugins/HTXSRivetProducer.cc:41:10: error: no viable overloaded '=' [clang-diagnostic-error]
    cat_ = nullptr;
         ^
/cvmfs/cms-ib.cern.ch/nweek-02646/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-09-15-1100/src/SimDataFormats/HTXS/interface/HiggsTemplateCrossSections.h:514:10: note: candidate function (the implicit move assignment operator) not viable: no known conversion from 'nullptr_t' to 'HTXS::HiggsClassification' for 1st argument
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[mrodozov]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31476/18392

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9365/console Started: 2020/09/16 02:05

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 3bb9037
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-599024/9365/summary.html
CMSSW: CMSSW_11_2_X_2020-09-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-599024/9365/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2620306
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2620272
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[agrohsje]

Thanks @Dr15Jones and @mrodozov for the fix.

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1