Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460

dildick · 2020-09-14T18:14:13Z

PR description:

First major part: The GEM-CSC trigger will use clusters in Run-3 (not single GEM pads) which will be sent to the ME1/1 optical trigger motherboards over 9.6 Gb/s optical fibers as explained in DN-20-016. This PR finally removes the option to run on single pads (which was the normal way since CMSSW_6_2_X_SLHC).
Second major part of the pull request is a working version of Clean-up CSC trigger configuration for Run-3 and Phase-2 #31401, with the intent of making the CSC trigger configuration easier to understand. All psets for ALCT, CLCT, TMB, MPC and CCLUT are put in python/params rather than directly in cscTriggerPrimitiveDigis_cfi, reducing the main configuration to less than 100 lines. Thus params/ contains

python/params/
* alctParams_cfi
* clctParams_cfi
* tmbParams_cfi
* auxiliaryParams_cfi
* cclutParams_cfi
* __init__.py

SLHC was renamed to Phase2 everwhere
alctClctOffset_ was made a constant, defined in CSCConstants.h
use_run3_patterns_ and use_comparator_codes_ were merged into runCCLUT_ (because we will not run the Run-3 patterns without CCLUT)

PR validation:

Tested with 23234.0. I also ran a validation on this relval /RelValSingleMuFlatPt2To100/CMSSW_11_0_0-110X_mcRun4_realistic_v2_2026D49noPU-v1/GEN-SIM-DIGI-RAW

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI @tahuang1991

cmsbuild · 2020-09-14T18:14:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-14T18:17:21Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-14T18:22:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31460/18364

This PR adds an extra 48KB to repository

cmsbuild · 2020-09-14T18:23:00Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

dildick · 2020-09-14T18:24:31Z

A few validation plots (not for publication):

True muon to single pad or single cluster matching efficiency vs |eta|. You can see that clusters are as efficient as single pads.

dildick · 2020-09-14T18:27:04Z

These are efficiencies to match a true muon to GEM-CSC integrated local triggers vs |eta|. The ME1/1 plot ends at |eta|~2.15, because GE1/1 does not cover the bottom part of ME1/1.

.

And true muon to EMTF track matching efficiencies

dildick · 2020-09-14T18:29:11Z

I don't see a drop in ME1/1 or ME2/1 integrated local trigger efficiency or in the EMTF trigger efficiency.

cmsbuild · 2020-09-14T20:34:38Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-14T20:35:50Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-14T20:40:10Z

-code-checks

ERROR: Build errors found during clang-tidy run.

gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

dildick · 2020-09-14T20:43:06Z

A few more validation plots (on single muon with PU0) after cleaning up the configuration code. The next few plots compare the 4-layer CLCT reconstruction efficiency for Run-1/2 (still the default in CMSSW) and Run-3 patterns (when runCCLUT set to True).

EMTF track efficiency

cmsbuild · 2020-09-14T20:50:49Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-14T20:57:01Z

-code-checks

ERROR: Build errors found during clang-tidy run.

gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

dildick · 2020-09-25T05:13:03Z

There should only be two: (125,125) and (125,126). Somehow they appear 8 times each in the collection.

dildick · 2020-09-25T14:12:03Z

Weird, somehow the coincidence pad collection is not being cleared for each event...

Begin processing the 3rd record. Run 1, Event 3, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:45.222 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
Begin processing the 4th record. Run 1, Event 4, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:45.708 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
Begin processing the 5th record. Run 1, Event 5, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:46.174 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
Begin processing the 6th record. Run 1, Event 6, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:46.662 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
Begin processing the 7th record. Run 1, Event 7, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:47.136 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
Begin processing the 8th record. Run 1, Event 8, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:47.638 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
Begin processing the 9th record. Run 1, Event 9, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:48.105 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
Begin processing the 10th record. Run 1, Event 10, LumiSection 1 on stream 0 at 25-Sep-2020 09:10:48.588 CDT
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 125 bx = 0
 Re -1 Ri 1 St 1 La 0 Ch 29 Ro 0  Roll: 1 layer1: GEMPadDigi Pad = 125 bx = 0, layer2: GEMPadDigi Pad = 126 bx = 0
25-Sep-2020 09:10:49 CDT  Closed file file:step2.root

cmsbuild · 2020-09-25T14:43:50Z

The code-checks are being triggered in jenkins.

dildick · 2020-09-25T14:46:12Z

So while the GEM coincidence pad vector in the motherboard was being cleared each event, the vector internal in the GEM processor was only being cleared when there were GEM hits in the event. This is now fixed.

@mrodozov Could you rerun the tests again?

cmsbuild · 2020-09-25T14:49:18Z

-code-checks

ERROR: Build errors found during clang-tidy run.

gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

silviodonato · 2020-09-29T10:13:37Z

code-checks

cmsbuild · 2020-09-29T10:14:03Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-29T10:18:24Z

-code-checks

ERROR: Build errors found during clang-tidy run.

gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild added this to the CMSSW_11_2_X milestone Sep 14, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Sep 14, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 14, 2020

dildick changed the title ~~Remove option to run on single GEM pads~~ Remove option to run on single GEM pads; Simplify CSC trigger configuration Sep 14, 2020

cmsbuild added code-checks-pending and removed code-checks-approved labels Sep 14, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 14, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 14, 2020

cmsbuild removed the code-checks-pending label Sep 14, 2020

Sven Dildick added 6 commits September 25, 2020 08:12

Remove option to run on single pads

78a0d50

Code format

b3eb97e

Simplify CSC trigger configuration

cd3356e

Code format

2fd9c65

Fix mistakes

b02a7ab

Fix Run-1/2 WFs

1968c27

Clean coincidence pad collection before each event

38b63b8

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-rejected comparison-available tests-approved labels Sep 25, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 25, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 29, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 29, 2020

dildick closed this Sep 30, 2020

dildick mentioned this pull request Sep 30, 2020

Remove option to run on single GEM pads; Simplify CSC trigger configuration #31631

Merged

dildick deleted the from-CMSSW_11_2_X_2020-09-14-1100-remove-option-pads branch September 30, 2020 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460

Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460

dildick commented Sep 14, 2020 •

edited

Loading

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

dildick commented Sep 14, 2020 •

edited

Loading

dildick commented Sep 14, 2020 •

edited

Loading

dildick commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

dildick commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

dildick commented Sep 25, 2020 •

edited

Loading

dildick commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

dildick commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

silviodonato commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460

Remove option to run on single GEM pads; Simplify CSC trigger configuration #31460

Conversation

dildick commented Sep 14, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

dildick commented Sep 14, 2020 • edited Loading

dildick commented Sep 14, 2020 • edited Loading

dildick commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

dildick commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

cmsbuild commented Sep 14, 2020

dildick commented Sep 25, 2020 • edited Loading

dildick commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

dildick commented Sep 25, 2020

cmsbuild commented Sep 25, 2020

silviodonato commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

cmsbuild commented Sep 29, 2020

dildick commented Sep 14, 2020 •

edited

Loading

dildick commented Sep 14, 2020 •

edited

Loading

dildick commented Sep 14, 2020 •

edited

Loading

dildick commented Sep 25, 2020 •

edited

Loading