chi2_vs_drj and pull_vs_pt validation plots #31400
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1099,6 +1099,8 @@ void MTVHistoProducerAlgoForTracker::bookRecoHistos(DQMStore::IBooker& ibook, | |
| ibook.bookProfile("chi2mean_vs_phi", "mean #chi^{2} vs #phi", nintPhi, minPhi, maxPhi, 200, 0, 20, " ")); | ||
| histograms.chi2_vs_pt.push_back( | ||
| makeProfileIfLogX(ibook, useLogPt, "chi2mean_vs_pt", "mean #chi^{2} vs p_{T}", nintPt, minPt, maxPt, 0, 20)); | ||
| histograms.chi2_vs_drj.push_back(makeProfileIfLogX( | ||
| ibook, true, "chi2mean_vs_drj", "mean #chi^{2} vs dR(track,jet)", nintdrj, log10(mindrj), log10(maxdrj), 0, 20)); | ||
|
|
||
| histograms.assoc_chi2_vs_eta.push_back( | ||
| ibook.bookProfile("assoc_chi2mean", "mean #chi^{2} vs #eta", nintEta, minEta, maxEta, 200, 0., 20., " ")); | ||
|
|
@@ -1107,7 +1109,25 @@ void MTVHistoProducerAlgoForTracker::bookRecoHistos(DQMStore::IBooker& ibook, | |
| histograms.assoc_chi2_vs_pt.push_back(makeProfileIfLogX( | ||
| ibook, useLogPt, "assoc_chi2mean_vs_pt", "mean #chi^{2} vs p_{T}", nintPt, minPt, maxPt, 0., 20.)); | ||
| histograms.assoc_chi2prob_vs_pt.push_back(makeProfileIfLogX( | ||
|
There was a problem hiding this comment. here the only change in the plots I've done (max Y limit from 20 to 1, because it's a probability. I thought it was a typo from another PR copying from the line above). If I am wrong I change it back immediately. There was a problem hiding this comment. I agree with this update, thanks |
||
| ibook, useLogPt, "assoc_chi2prob_vs_pt", "mean #chi^{2} probability vs p_{T}", nintPt, minPt, maxPt, 0., 1.)); | ||
| histograms.assoc_chi2_vs_drj.push_back(makeProfileIfLogX(ibook, | ||
| true, | ||
| "assoc_chi2mean_vs_drj", | ||
| "mean #chi^{2} vs dR(track,jet)", | ||
| nintdrj, | ||
| log10(mindrj), | ||
| log10(maxdrj), | ||
| 0., | ||
| 20)); | ||
| histograms.assoc_chi2prob_vs_drj.push_back(makeProfileIfLogX(ibook, | ||
| true, | ||
| "assoc_chi2prob_vs_drj", | ||
| "mean #chi^{2} probability vs dR(track,jet)", | ||
| nintdrj, | ||
| log10(mindrj), | ||
| log10(maxdrj), | ||
| 0., | ||
| 1.)); | ||
|
|
||
| histograms.nhits_vs_eta.push_back( | ||
| ibook.bookProfile("hits_eta", "mean hits vs eta", nintEta, minEta, maxEta, nintHit, minHit, maxHit, " ")); | ||
|
|
@@ -1387,6 +1407,16 @@ void MTVHistoProducerAlgoForTracker::bookRecoHistos(DQMStore::IBooker& ibook, | |
| histograms.phipull_vs_eta, false, "phipull_vs_eta", "phipull_vs_eta", nintEta, minEta, maxEta, 100, -10, 10); | ||
| bookResolutionPlots2D( | ||
| histograms.thetapull_vs_eta, false, "thetapull_vs_eta", "thetapull_vs_eta", nintEta, minEta, maxEta, 100, -10, 10); | ||
| bookResolutionPlots2D( | ||
| histograms.dxypull_vs_pt, useLogPt, "dxypull_vs_pt", "dxypull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); | ||
| bookResolutionPlots2D( | ||
| histograms.ptpull_vs_pt, useLogPt, "ptpull_vs_pt", "ptpull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); | ||
| bookResolutionPlots2D( | ||
| histograms.dzpull_vs_pt, useLogPt, "dzpull_vs_pt", "dzpull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); | ||
| bookResolutionPlots2D( | ||
| histograms.phipull_vs_pt, useLogPt, "phipull_vs_pt", "phipull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); | ||
| bookResolutionPlots2D( | ||
| histograms.thetapull_vs_pt, useLogPt, "thetapull_vs_pt", "thetapull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); | ||
|
|
||
| // histograms.h_ptshiftetamean.push_back( ibook.book1D("h_ptshifteta_Mean","<#deltapT/pT>[%] vs #eta",nintEta,minEta,maxEta) ); | ||
|
|
||
|
|
@@ -2026,6 +2056,7 @@ void MTVHistoProducerAlgoForTracker::fill_generic_recoTrack_histos(const Histogr | |
| histograms.h_recozpos[count]->Fill(vertz); | ||
| histograms.h_recodr[count]->Fill(dR); | ||
| histograms.h_recodrj[count]->Fill(dRJet); | ||
| histograms.chi2_vs_drj[count]->Fill(dRJet, chi2); | ||
|
There was a problem hiding this comment. I think the problem in the @mmusich plot can be here: I am filling this plot here (in the recoTrack part), instead of simAssociated_recoTrack (like the chi2_vs_otherVariables), because dR(jet,track) is not available at sim level. If this produces unreasonable results I'll remove it (we still a have "assoc_chi2_vs_drj" for a similar purpose). There was a problem hiding this comment. Valerio, I clicked semi-randomly on several folders so that exact plot I am not sure, but e.g. you can look to |
||
| if (fillSeedingLayerSets) | ||
| histograms.h_reco_seedingLayerSet[count]->Fill(seedingLayerSetBin); | ||
| if (pvPosition) { | ||
|
|
@@ -2089,6 +2120,8 @@ void MTVHistoProducerAlgoForTracker::fill_generic_recoTrack_histos(const Histogr | |
| histograms.assoc_chi2prob_vs_eta[count]->Fill(eta, chi2prob); | ||
| histograms.assoc_chi2_vs_pt[count]->Fill(pt, chi2); | ||
| histograms.assoc_chi2prob_vs_pt[count]->Fill(pt, chi2prob); | ||
| histograms.assoc_chi2_vs_drj[count]->Fill(dRJet, chi2); | ||
| histograms.assoc_chi2prob_vs_drj[count]->Fill(dRJet, chi2prob); | ||
| histograms.h_assoc2vertpos[count]->Fill(vertxy); | ||
| histograms.h_assoc2zpos[count]->Fill(vertz); | ||
| histograms.h_assoc2dr[count]->Fill(dR); | ||
|
|
@@ -2481,6 +2514,13 @@ void MTVHistoProducerAlgoForTracker::fill_ResoAndPull_recoTrack_histos(const His | |
| histograms.phipull_vs_eta[count]->Fill(etaSim, phiPull); | ||
| histograms.thetapull_vs_eta[count]->Fill(etaSim, thetaPull); | ||
|
|
||
| //pulls of track params vs pt: fill 2D histos | ||
| histograms.dxypull_vs_pt[count]->Fill(ptSim, dxyPull); | ||
| histograms.ptpull_vs_pt[count]->Fill(ptSim, ptres / ptError); | ||
| histograms.dzpull_vs_pt[count]->Fill(ptSim, dzPull); | ||
| histograms.phipull_vs_pt[count]->Fill(ptSim, phiPull); | ||
| histograms.thetapull_vs_pt[count]->Fill(ptSim, thetaPull); | ||
|
|
||
| //plots vs phi | ||
| histograms.nhits_vs_phi[count]->Fill(phiRec, track.numberOfValidHits()); | ||
| histograms.chi2_vs_phi[count]->Fill(phiRec, track.normalizedChi2()); | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need these 2 modules in production ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, with the current configuration (are part of the setup of MTV to be able to easily switch to associator by chi2, but if you think they create mess I remove it... For my understanding, they are not running on anything).