Biased tau decayer update #31353
Biased tau decayer update #31353
Conversation
|
The code-checks are being triggered in jenkins. |
|
@intrepid42 @mkirsano This should address the changes for Pythia8.30X. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31353/18136
|
|
A new Pull Request was created by @smrenna (Stephen Mrenna) for master. It involves the following packages: GeneratorInterface/Pythia8Interface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@cms-sw/generators-l2 any comments? |
| Settings* settingsPtr, | ||
| ParticleData* particleDataPtr, | ||
| Rndm* rndmPtr) { | ||
| BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) { |
There was a problem hiding this comment.
Hi @smrenna . I seems to overlook something. Where do we propagate Settings* settingsPtr to P8, or differently asked, what happens to this argument in BiasedTauDecayer ?
|
Hi @smrenna. Sorry, let me rephrase: What is the second argument in BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) used for in the code. I cannot find it. |
|
// Specialized decayer for resonance decays to taus to allowing biasing to
// leptonic decays
//
BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) {
decayer = TauDecays();
decayer.initInfoPtr(*infoPtr);
decayer.init();
filter_ = settingsPtr->flag("BiasedTauDecayer:filter");
eDecays_ = settingsPtr->flag("BiasedTauDecayer:eDecays");
muDecays_ = settingsPtr->flag("BiasedTauDecayer:muDecays");
}
From: agrohsje <[email protected]>
Reply-To: cms-sw/cmssw <[email protected]>
Date: Wednesday, September 9, 2020 at 10:59 AM
To: cms-sw/cmssw <[email protected]>
Cc: Stephen Mrenna <[email protected]>, Mention <[email protected]>
Subject: Re: [cms-sw/cmssw] Biased tau decayer update (#31353)
Hi @smrenna<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_smrenna&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=lpE2-TUc4fwylcrb7Hjs7lhKIc39Fe6zL222Qc5Rj1M&s=xnNjPG-LQrZJdQvoPNuzDv_OEP9cAYj6novmn7EcYlM&e=>. Sorry, let me rephrase: What is the second argument in BiasedTauDecayer::BiasedTauDecayer(Info* infoPtr, Settings* settingsPtr) used for in the code. I cannot find it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_31353-23issuecomment-2D689657115&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=lpE2-TUc4fwylcrb7Hjs7lhKIc39Fe6zL222Qc5Rj1M&s=s-UF-2iLyiL4nFDuxsFsGBZ_vgqqBY9PBmx0FxnEbEM&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABLSEJDLPCLSI66WS6FWOTLSE6Q5TANCNFSM4QU4VZJA&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=lpE2-TUc4fwylcrb7Hjs7lhKIc39Fe6zL222Qc5Rj1M&s=D9_WdKdI8ekpLKbJdLEoK4r7Z0WX56GefgamUHc0PKE&e=>.
|
|
Sorry @smrenna. Don't ask me why I overlooked it. |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This is an update to the biasedTauDecayer that reflects changes to the structure of
Pythia8.30X. In particular, the way that Pythia8::Info is handled is different.
There is now more protection from allowing an external user to change Info.
PR validation:
The original test (that failed) is passed ZToTauTau_photos_13TeV_rivet_cfg.py
Also, a new test "biasedTauDecayer.py" was added.
if this PR is a backport please specify the original PR and why you need to backport that PR: