Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break circular dependencies reported by IB system #31344

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

davidlange6
Copy link
Contributor

looks like these were simply extract #includes that could be removed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31344/18115

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
EventFilter/HcalRawToDigi
RecoLocalCalo/HGCalRecAlgos
TrackingTools/KalmanUpdators

@perrotta, @benkrikler, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @kpedro88, @tlampen, @jpata, @pohsun can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @argiro, @Martin-Grunewald, @pfs, @mmusich, @cericeci, @sethzenz, @makortel, @abdoulline, @JanFSchulte, @jhgoh, @lgray, @apsallid, @HuguesBrun, @trocino, @vandreev11, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @bellan, @tocheng, @deguio, @hatakeyamak, @ebrondol, @mtosi, @dgulhan, @clelange, @rchatter, @riga, @Fedespring, @edjtscott, @calderona, @lecriste, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Sep 3, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

+1
Tested at: c8fff14
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-351469/9084/summary.html
CMSSW: CMSSW_11_2_X_2020-09-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-351469/9084/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 3, 2020

+upgrade

@slava77
Copy link
Contributor

slava77 commented Sep 3, 2020

+1

for #31344 c8fff14

  • technical; compiles and runs OK

@silviodonato
Copy link
Contributor

any objections @cms-sw/alca-l2 @cms-sw/l1-l2 ?

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4ace804 into cms-sw:master Sep 4, 2020
rovere added a commit to rovere/cmssw that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants