-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small enhancements to geometry DB payload validation scripts #31320
Small enhancements to geometry DB payload validation scripts #31320
Conversation
…osalo/cmssw into cvuosalo/fix-payload-scripts
…osalo/cmssw into cvuosalo/fix-payload-scripts
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31320/18077
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages: DetectorDescription/OfflineDBLoader @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31320/18150
|
Pull request #31320 was updated. @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kmaeshima, @jfernan2, @fioriNTU, @civanch can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
runDDDvsDBGeometryValidation.sh
compares new geometry DB payloads with the geometry XML files and the payloads in the Conditions DB. It will show differences down to the level of |1.e-23|. This PR adds the option to reduce the precision of comparison to |1.e-7| to allow focusing on big differences without being overwhelmed with tiny numerical fluctuations.Also, values in simulation geometry that are shown to four decimal places are rounded to zero if they are < |5.e-5| to avoid showing differences between 0.0000 and -0.0000, which are not very helpful.
These scripts are for expert use and have no effect on production workflows.
No backport is needed.