-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ideal pixel bad components and remove obsolete pixel tags for Phase-2 simulation #31316
Use ideal pixel bad components and remove obsolete pixel tags for Phase-2 simulation #31316
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31316/18064
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: Configuration/AlCa @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thanks @christopheralanwest, can the title of the PR reflect that the update concerns only phase-2 simulation, for ease of comprehension of people parsing the release diff when performing validation? |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
For the record, the DQM bin-by-bin comparison shows the issue is removed: (link) |
PR description:
Currently the phase 2 pixel bad component record (
SiPixelQualityFromDbRcd
) uses a tag intended for 2018 MC simulation. This "works" on a technical level only by accident but does not specify any sort of physically sensible list of bad components. This PR updates the pixel bad component record to use a payload that models an ideal detector with no bad components. In addition, several obsolete pixel tags have been removed. Please refer to the presentation at the 13 August 2020 AlCaDB meeting for further details.The GT diff can be found below.
Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun4_realistic_v1/112X_mcRun4_realistic_v2
PR validation:
Please see the presentation at the 13 August 2020 AlCaDB meeting for details. In addition, a technical test was performed:
runTheMatrix.py -l limited --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport but will be backported to 11_1_X.