Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ideal pixel bad components and remove obsolete pixel tags for Phase-2 simulation #31316

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

Currently the phase 2 pixel bad component record (SiPixelQualityFromDbRcd) uses a tag intended for 2018 MC simulation. This "works" on a technical level only by accident but does not specify any sort of physically sensible list of bad components. This PR updates the pixel bad component record to use a payload that models an ideal detector with no bad components. In addition, several obsolete pixel tags have been removed. Please refer to the presentation at the 13 August 2020 AlCaDB meeting for further details.

The GT diff can be found below.

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_mcRun4_realistic_v1/112X_mcRun4_realistic_v2

PR validation:

Please see the presentation at the 13 August 2020 AlCaDB meeting for details. In addition, a technical test was performed:

runTheMatrix.py -l limited --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but will be backported to 11_1_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31316/18064

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 1, 2020

Thanks @christopheralanwest, can the title of the PR reflect that the update concerns only phase-2 simulation, for ease of comprehension of people parsing the release diff when performing validation?

@christopheralanwest christopheralanwest changed the title Use ideal pixel bad components and remove obsolete pixel tags Use ideal pixel bad components and remove obsolete pixel tags for Phase-2 simulation Sep 1, 2020
@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

+1
Tested at: 82d004d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10de8d/9040/summary.html
CMSSW: CMSSW_11_2_X_2020-09-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10de8d/9040/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2894 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 41256
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2568388
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@tlampen
Copy link
Contributor

tlampen commented Sep 2, 2020

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d37b891 into cms-sw:master Sep 2, 2020
@mmusich
Copy link
Contributor

mmusich commented Sep 2, 2020

For the record, the DQM bin-by-bin comparison shows the issue is removed:

image

(link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants