Remove use of deprecated tbb::task_scheduler_init from FWCore #31313

Dr15Jones · 2020-09-01T14:50:55Z

PR description:

Use tbb::global_control and an explicit tbb::task_arena to control number of threads. The explicit task_arena allows for the possibility of allowing oversubscribing the number of threads used (helpful for scale testing).
Removed all direct use of edm::EventProcessor outside of FWCore. This avoids having to deal with restricting the number of threads to use outside of FWCore.

PR validation:

all FWCore unit tests pass
did runTheMatrix.py -l limited -t 4 and runTheMatrix.py -l limited -t 1 both of which were successful.

Replace explicit call to tbb::task_scheduler_init with new edm::ThreadsController.

Also make sure waiting task is spawned back into the same task_arena active during the original call.

Using tbb::task_arena together with tbb::global_control allows for oversubscribing the number of threads without having to use the deprecated tbb::task_scheduler_init.

The file is never built, was directly using edm::EventProcessor and using the old no-longer-supported configuration language syntax.

Avoid direct use of EventProcessor and instead just have test use cmsRun.

cmsbuild · 2020-09-01T14:51:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-09-01T14:57:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31313/18060

This PR adds an extra 88KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FWCore/Framework/src/Worker.cc modified in PR(s): Extend thinning to support slimming #31100, Use TransitionInfo in more interfaces, part 2 #31136, Delete unscheduled modules that are not consumed by any scheduled module #29553, Use TransitionInfo in more interfaces #30969
- File FWCore/Framework/test/eventsetup_t.cppunit.cc modified in PR(s): Throw a separate exception if ESGetToken is uninitialized #30506
- File FWCore/TestProcessor/src/TestProcessor.cc modified in PR(s): Use TransitionInfo in more interfaces, part 2 #31136, Use TransitionInfo in more interfaces #30969

cmsbuild · 2020-09-01T14:58:04Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/CSCObjects
EventFilter/CSCTFRawToDigi
EventFilter/DTRawToDigi
FWCore/Concurrency
FWCore/Framework
FWCore/Integration
FWCore/PythonFramework
FWCore/TestProcessor
FWCore/Utilities

@perrotta, @smuzaffar, @benkrikler, @Dr15Jones, @jpata, @makortel, @tlampen, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @slava77, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@battibass, @makortel, @felicepantaleo, @wddgit, @Martin-Grunewald, @ptcox, @tocheng, @dildick, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-09-01T15:01:31Z

please test

cmsbuild · 2020-09-01T15:01:58Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-01-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9038/console Started: 2020/09/01 17:02

makortel · 2020-09-01T15:03:19Z

Resolves #29753

cmsbuild · 2020-09-01T16:24:47Z

-1

Tested at: 8ee085c

CMSSW: CMSSW_11_2_X_2020-09-01-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c4db6/9038/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testGeneratorInterfaceLHEInterface_TP had ERRORS

cmsbuild · 2020-09-01T16:24:48Z

Comparison job queued.

cmsbuild · 2020-09-03T19:41:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c4db6/9105/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609667
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609644
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

makortel · 2020-09-03T20:27:20Z

+1

slava77 · 2020-09-03T21:06:44Z

+1

for #31313 c645fae

new changes since the last reco signoff were outside of reco, in FWCore

pohsun · 2020-09-07T05:56:26Z

+1

Dr15Jones · 2020-09-07T12:32:03Z

ping @cms-sw/db-l2 @cms-sw/l1-l2

ggovi · 2020-09-08T12:54:32Z

+1

Dr15Jones · 2020-09-08T13:18:21Z

please review @cms-sw/l1-l2

Dr15Jones · 2020-09-10T15:44:39Z

@cms-sw/l1-l2 yours is the last signature needed and the changes in your area were just

the removal of an uncompiled test program and
changing a test to no longer require a stand alone executable and instead use cmsRun directly.

smuzaffar · 2020-09-11T15:14:16Z

@silviodonato , L1 changes looks reasonable. Can we get this in?

silviodonato · 2020-09-11T18:56:34Z

merge
@rekovic

Dr15Jones added 7 commits August 29, 2020 13:26

Switch to using tbb::global_control

e9c55be

Use edm::ThreadsController to constrain threads

5c29b9c

Replace explicit call to tbb::task_scheduler_init with new edm::ThreadsController.

Use tbb::global_control to determine if using only 1 thread

654bd25

Also make sure waiting task is spawned back into the same task_arena active during the original call.

Use explicit tbb::task_arena to control number of threads

e29b797

Using tbb::task_arena together with tbb::global_control allows for oversubscribing the number of threads without having to use the deprecated tbb::task_scheduler_init.

Removed unused EventProcessor calls

b540c6b

Removed unused file testDTUnpackingModule.cc

64122db

The file is never built, was directly using edm::EventProcessor and using the old no-longer-supported configuration language syntax.

Use cmsRun directly for test

8ee085c

Avoid direct use of EventProcessor and instead just have test use cmsRun.

cmsbuild added this to the CMSSW_11_2_X milestone Sep 1, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending core-pending db-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 1, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 3, 2020

cmsbuild added core-approved and removed core-pending labels Sep 3, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 3, 2020

This was referenced Sep 4, 2020

Throw a separate exception if ESGetToken is uninitialized #30506

Merged

Integrating VectorHits reconstruction for the Phase2 OT - reprise #31314

Merged

cmsbuild added alca-approved and removed alca-pending labels Sep 7, 2020

cmsbuild added db-approved and removed db-pending labels Sep 8, 2020

cmsbuild mentioned this pull request Sep 8, 2020

Improve FWCore/Framework/interface #31395

Merged

cmsbuild added orp-approved and removed orp-pending labels Sep 11, 2020

cmsbuild merged commit 753f6f3 into cms-sw:master Sep 11, 2020

cmsbuild mentioned this pull request Sep 12, 2020

Added configurable wait time for external process communication #31441

Merged

makortel mentioned this pull request Oct 8, 2020

tbb::task_scheduler_init is deprecated #29753

Closed

Dr15Jones deleted the tbbUpdate branch October 14, 2020 19:43

makortel mentioned this pull request Jan 4, 2021

TBB warning on 0 workers when running ExternalWork on a single thread #32597

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove use of deprecated tbb::task_scheduler_init from FWCore #31313

Remove use of deprecated tbb::task_scheduler_init from FWCore #31313

Dr15Jones commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

Dr15Jones commented Sep 1, 2020

cmsbuild commented Sep 1, 2020 •

edited

Loading

makortel commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

slava77 commented Sep 3, 2020

pohsun commented Sep 7, 2020

Dr15Jones commented Sep 7, 2020

ggovi commented Sep 8, 2020

Dr15Jones commented Sep 8, 2020

Dr15Jones commented Sep 10, 2020

smuzaffar commented Sep 11, 2020

silviodonato commented Sep 11, 2020

Remove use of deprecated tbb::task_scheduler_init from FWCore #31313

Remove use of deprecated tbb::task_scheduler_init from FWCore #31313

Conversation

Dr15Jones commented Sep 1, 2020

PR description:

PR validation:

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

Dr15Jones commented Sep 1, 2020

cmsbuild commented Sep 1, 2020 • edited Loading

makortel commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 1, 2020

cmsbuild commented Sep 3, 2020

makortel commented Sep 3, 2020

slava77 commented Sep 3, 2020

pohsun commented Sep 7, 2020

Dr15Jones commented Sep 7, 2020

ggovi commented Sep 8, 2020

Dr15Jones commented Sep 8, 2020

Dr15Jones commented Sep 10, 2020

smuzaffar commented Sep 11, 2020

silviodonato commented Sep 11, 2020

cmsbuild commented Sep 1, 2020 •

edited

Loading