-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused fwd headers in DataFormats/TrackerRecHit2D #31312
Conversation
…pe defs like this
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31312/18059
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: DataFormats/TrackerRecHit2D @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31312/18068
|
please test
On 1 Sep 2020, at 21:04, cmsbuild <[email protected]> wrote:
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31312/18068
* This PR adds an extra 16KB to repository
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#31312 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ7FM3JY5IRUEZNYLZDSDVAPVANCNFSM4QRZU3LA>.
|
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
(good thing, as you cant forward declare type defs like this)