fixed typo for recHitEE_

[jwill24]

PR description:

Providing a fix for a gainSeed issue with the EGM producer in nanoAOD corresponding to cms-nanoAOD#534

A typo was causing the issue. The correction was to change recHitsEB_ ---> recHitsEE_.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31293/18011

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jwill24 (Justin Williams) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-29-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9004/console Started: 2020/08/29 23:17

[cmsbuild]

+1
Tested at: d280640
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec13da/9004/summary.html
CMSSW: CMSSW_11_2_X_2020-08-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec13da/9004/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[mariadalfonso]

@jwill24
no difference are found by automatic tests.
can on report/document on which sample you saw that fixing this typo will fix the gainSeed problem ?

[mariadalfonso]

type bug-fix

[santocch]

+1

[mariadalfonso]

@jwill24
no difference are found by automatic tests.
can on report/document on which sample you saw that fixing this typo will fix the gainSeed problem ?

@jwill24 @jainshilpi

[jwill24]

I tested the code before and after I fixed the typo. I printed the subdetector for the "recHitsEE" collection. Before the fix, the EB rechits were assigned to this collection. Now, the EE recHits are correctly assigned to this collection.
I am using the following dataset: /DoubleEG/Run2017F-09Aug2019_UL2017-v1/MINIAOD
Here is a print out of my test before and after the fix:

Begin processing the 1st record. Run 306125, Event 1681216989, LumiSection 927 on stream 0 at 04-Sep-2020 11:07:58.151 CDT
Before fix ----> Event: 1681216989, recHitsEE subdet: 1
Begin processing the 2nd record. Run 306125, Event 1680484069, LumiSection 927 on stream 0 at 04-Sep-2020 11:08:12.523 CDT
Before fix ----> Event: 1680484069, recHitsEE subdet: 1

Begin processing the 1st record. Run 306125, Event 1681216989, LumiSection 927 on stream 0 at 04-Sep-2020 11:16:40.642 CDT
After fix ----> Event: 1681216989, recHitsEE subdet: 2
Begin processing the 2nd record. Run 306125, Event 1680484069, LumiSection 927 on stream 0 at 04-Sep-2020 11:16:53.587 CDT
After fix ----> Event: 1680484069, recHitsEE subdet: 2

[mariadalfonso]

questions:

1. can you check that the seedGain is actually fixed for your events
   

   cmssw/PhysicsTools/NanoAOD/python/nanoDQM_cfi.py

   Line 111 in 503f805

   Plot1D('seedGain', 'seedGain', 12, 0.5, 12.5, 'Gain of the seed crystal'),

2. his producer is re-runned for previous eras,
   

   cmssw/PhysicsTools/NanoAOD/python/electrons_cff.py

   Line 167 in 503f805

   for modifier in run2_nanoAOD_94XMiniAODv1,run2_nanoAOD_94XMiniAODv2,run2_nanoAOD_94X2016 ,run2_nanoAOD_102Xv1:

   
   for the 10_6 and onwards is in the miniAOD ?

[jwill24]

Yes, the seedGain is now for the correct collections.

[silviodonato]

do you have further comments? @cms-sw/xpog-l2

[mariadalfonso]

+xpog
fix valid for all the nanos made so far

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[mariadalfonso]

@jwill24
consider back porting this PR to 10_6

[jwill24]

@mariadalfonso I have started the back port PR. See #31497