Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PixelCPEInitial_cfi and PixelCPEParmError_cfi and all their occurences #31292

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 29, 2020

PR description:

This PR removes two ancient pieces of configuration RecoLocalTracker/SiPixelRecHits/python/PixelCPEInitial_cfi.py and RecoLocalTracker/SiPixelRecHits/python/PixelCPEParmError_cfi.py supposed to support Pixel CPE ESproducers that do not even exist anymore in cmssw. All occurrences in other subsystems are removed as well.

PR validation:

Passes runTheMatrix.py -l limited --ibeos
Zero regressions expected.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.
cc: @tvami @tsusa

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31292/18010

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/LaserAlignment
Alignment/MillePedeAlignmentAlgorithm
DQM/SiStripCommissioningSources
RecoEgamma/EgammaPhotonProducers
RecoLocalTracker/SiPixelRecHits
RecoMuon/CosmicMuonProducer
RecoMuon/GlobalMuonProducer
RecoMuon/L3TrackFinder
RecoMuon/TrackerSeedGenerator
RecoPixelVertexing/PixelTrackFitting
RecoTracker/CkfPattern
RecoTracker/SpecialSeedGenerators
RecoTracker/TkSeedGenerator
RecoTracker/TrackProducer
TrackingTools/GsfTracking
TrackingTools/TrackRefitter

@perrotta, @Martin-Grunewald, @andrius-k, @kmaeshima, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @jfernan2, @fioriNTU, @tlampen, @jpata, @fwyzard, @pohsun can you please review it and eventually sign? Thanks.
@erikbutz, @felicepantaleo, @jainshilpi, @abbiendi, @echapon, @tlampen, @lgray, @threus, @mmusich, @cericeci, @makortel, @JanFSchulte, @jhgoh, @varuns23, @dkotlins, @trocino, @rociovilar, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @mschrode, @ebrondol, @mtosi, @dgulhan, @HuguesBrun, @adewit, @Fedespring, @calderona, @sobhatta, @lecriste, @afiqaize, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 29, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 618b6d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e579f/9003/summary.html
CMSSW: CMSSW_11_2_X_2020-08-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e579f/9003/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2609644
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #31292 was updated. @perrotta, @Martin-Grunewald, @andrius-k, @kmaeshima, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @jfernan2, @fioriNTU, @tlampen, @jpata, @fwyzard, @pohsun can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1
Tested at: 418edbf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e579f/9005/summary.html
CMSSW: CMSSW_11_2_X_2020-08-30-0000
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e579f/9005/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609639
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@pohsun
Copy link

pohsun commented Aug 31, 2020

+1

@Martin-Grunewald
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1

  • Removed unused PixelCPEInitial_cfi and PixelCPEParmError_cfi, as well as all their inclusions in other configs
  • Jenkins tests pass and show no differences in reco outputs

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7a0b4a1 into cms-sw:master Aug 31, 2020
@mmusich mmusich deleted the remove_unused_Pixel_CPE_configurations branch September 1, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants