-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove PixelCPEInitial_cfi and PixelCPEParmError_cfi and all their occurences #31292
remove PixelCPEInitial_cfi and PixelCPEParmError_cfi and all their occurences #31292
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31292/18010
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/LaserAlignment @perrotta, @Martin-Grunewald, @andrius-k, @kmaeshima, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @jfernan2, @fioriNTU, @tlampen, @jpata, @fwyzard, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
618b6d2
to
2b82c14
Compare
Pull request #31292 was updated. @perrotta, @Martin-Grunewald, @andrius-k, @kmaeshima, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @jfernan2, @fioriNTU, @tlampen, @jpata, @fwyzard, @pohsun can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes two ancient pieces of configuration
RecoLocalTracker/SiPixelRecHits/python/PixelCPEInitial_cfi.py
andRecoLocalTracker/SiPixelRecHits/python/PixelCPEParmError_cfi.py
supposed to support Pixel CPEESproducer
s that do not even exist anymore incmssw
. All occurrences in other subsystems are removed as well.PR validation:
Passes
runTheMatrix.py -l limited --ibeos
Zero regressions expected.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, no backport is needed.
cc: @tvami @tsusa