-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add namespace to duplicated MuScleFitCorrector_Functions code as already done for MuScleFitCorrector to avoid duplicates #31248
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31248/17905
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: PhysicsTools/Heppy @cmsbuild, @santocch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test
On Aug 26, 2020, at 8:32 AM, cmsbuild <[email protected]<mailto:[email protected]>> wrote:
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31248/17905
* This PR adds an extra 12KB to repository
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#31248 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ6X3IAOJF4RAC6VMATSCSUA5ANCNFSM4QLOI4FA>.
|
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
one way to close #31000