Migrate GEM/CSC validation to esConsumes #31102
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31102/17654
|
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: Validation/MuonCSCDigis @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Thanks! |
| @@ -56,8 +55,7 @@ void CSCDigiValidation::analyze(const edm::Event &e, const edm::EventSetup &even | |||
| theSimHitMap.fill(e); | |||
|
|
|||
| // find the geometry & conditions for this event | |||
| edm::ESHandle<CSCGeometry> hGeom; | |||
| eventSetup.get<MuonGeometryRecord>().get(hGeom); | |||
| edm::ESHandle<CSCGeometry> hGeom = eventSetup.getHandle(geomToken_); | |||
There was a problem hiding this comment.
You could make your life a bit easier by doing
const CSCGeometry *pGeom = &eventSetup.getData(geomToken_);
dildick
changed the title
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31102/17661
|
|
Pull request #31102 was updated. @benkrikler, @kmaeshima, @andrius-k, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please check and sign again. |
cmsbuild
added
code-checks-pending
reconstruction-pending
and removed
code-checks-approved
labels
|
The code-checks are being triggered in jenkins. |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1
|
|
@rekovic Could you sign off, please? Thank you. |
|
kind reminder @cms-sw/l1-l2 |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
dildick
deleted the
from-CMSSW_11_2_X_2020-08-06-1100-csc-validation-handles
branch
PR description:
Migrate GEM and CSC validation to esConsumes and edm::ESGetToken to provide better threading efficiency, in response to #31061.
Included:
RecoLocalMuon/CSCEfficiency
RecoLocalMuon/CSCValidation
Validation/CSCRecHits
Validation/MuonCSCDigis
Validation/MuonGEMDigis
Validation/MuonGEMHits
Validation/MuonGEMRecHits
Validation/MuonHits
Validation/MuonME0Validation
PR validation:
Tested with WF 23234.0
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A