PPS: adding missing IO rule for class TotemRPUVPattern

[jan-kaspar]

PR description:

#28252 renamed data members of class TotemRPUVPattern. It provided IO rules for backward compatibility with previously created ROOT files. Unfortunately, an IO rule for projection data member was missing. The present PR adds this missing PR.

PR validation

This PR was tested with a UL AOD file (created with 10_6 which doesn't have the class members renamed). Before applying the proposed change, the method TotemRPUVPattern::projection() returns 0 (invalid). With the proposed changes, the method returns 1 or 2, as expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31075/17600

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

DataFormats/CTPPSReco

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@forthommel, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-05-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8614/console Started: 2020/08/06 15:28

[cmsbuild]

+1
Tested at: bf84fac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6a34e/8614/summary.html
CMSSW: CMSSW_11_2_X_2020-08-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6a34e/8614/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612401
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2612347
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[perrotta]

+1

• Technical fix for the update of "TotemRPUVPattern" from ClassVersion 2 to ClassVersion 3
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@jan-kaspar @forthommel : the UL release cycle 10_6 still uses ClassVersion 2, and therefore no backport is needed.

Do you think a backport to 11_1 can be useful? I.e., do you foresee any usage in the Phase2 HLT-TDR related samples (produced with V2 and readout in 11_1 with V3) and/or MWGRs? I don't think so, but please confirm.

[jan-kaspar]

@jan-kaspar @forthommel : the UL release cycle 10_6 still uses ClassVersion 2, and therefore no backport is needed.

Do you think a backport to 11_1 can be useful? I.e., do you foresee any usage in the Phase2 HLT-TDR related samples (produced with V2 and readout in 11_1 with V3) and/or MWGRs? I don't think so, but please confirm.

PPS doesn't plan on using strip RPs (related to the class in question) in the future (except special runs). Therefore all the studies I can imagine would be related to Run2 data where 10_6 can be used. Consequently, I don't think we need a backport to 11_1.

[silviodonato]

+1