missing buildfile dependencies in DataFormats and CondFormats #31005

davidlange6 · 2020-07-31T12:37:31Z

as usual - just grepping for #include...

cmsbuild · 2020-07-31T12:38:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-31T12:43:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31005/17468

This PR adds an extra 44KB to repository

davidlange6 · 2020-07-31T12:44:08Z

please test

cmsbuild · 2020-07-31T12:44:22Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-31-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8467/console Started: 2020/07/31 14:52

cmsbuild · 2020-07-31T12:44:23Z

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CondFormats/AlignmentRecord
CondFormats/CSCObjects
CondFormats/CastorObjects
CondFormats/DTObjects
CondFormats/DataRecord
CondFormats/ESObjects
CondFormats/EcalCorrections
CondFormats/EcalObjects
CondFormats/External
CondFormats/GEMObjects
CondFormats/GeometryObjects
CondFormats/JetMETObjects
CondFormats/MFObjects
CondFormats/PPSObjects
CondFormats/SiPixelTransient
DataFormats/Alignment
DataFormats/BTauReco
DataFormats/BeamSpot
DataFormats/CSCDigi
DataFormats/CTPPSDetId
DataFormats/CTPPSDigi
DataFormats/CTPPSReco
DataFormats/CastorReco
DataFormats/DTDigi
DataFormats/EcalDigi
DataFormats/EcalRecHit
DataFormats/EgammaCandidates
DataFormats/EgammaReco
DataFormats/EgammaTrackReco
DataFormats/FP420Cluster
DataFormats/FTLDigi
DataFormats/FTLRecHit
DataFormats/GEMDigi
DataFormats/GEMRecHit
DataFormats/GeometrySurface
DataFormats/GsfTrackReco
DataFormats/HGCDigi
DataFormats/HGCRecHit
DataFormats/HGCalReco
DataFormats/HLTReco
DataFormats/HcalCalibObjects
DataFormats/HcalDetId
DataFormats/HcalDigi
DataFormats/Histograms
DataFormats/JetReco
DataFormats/L1TCalorimeterPhase2
DataFormats/L1TCorrelator
DataFormats/L1TGlobal
DataFormats/L1THGCal
DataFormats/L1TMuon
DataFormats/L1TParticleFlow
DataFormats/L1TrackTrigger
DataFormats/L1Trigger
DataFormats/LTCDigi
DataFormats/Luminosity
DataFormats/METReco
DataFormats/Math
DataFormats/MuonReco
DataFormats/MuonSeed
DataFormats/OnlineMetaData
DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/ProtonReco
DataFormats/Provenance
DataFormats/RPCDigi
DataFormats/RecoCandidate
DataFormats/SiPixelCluster
DataFormats/SiPixelDetId
DataFormats/SiPixelRawData
DataFormats/SiStripCluster
DataFormats/SiStripCommon
DataFormats/Streamer
DataFormats/TauReco
DataFormats/TestObjects
DataFormats/TrackCandidate
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
DataFormats/TrajectoryState
DataFormats/VertexReco

@andrius-k, @ggovi, @christopheralanwest, @kpedro88, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @fwyzard, @smuzaffar, @Dr15Jones, @tocheng, @jfernan2, @mdhildreth, @slava77, @jpata, @benkrikler, @kmaeshima, @emeschi, @mommsen can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @gouskos, @echabert, @felicepantaleo, @jainshilpi, @hatakeyamak, @robervalwalsh, @emilbols, @sviret, @argiro, @jshlee, @Fedespring, @thomreis, @ahinzmann, @lgray, @abbiendi, @varuns23, @seemasharmafnal, @mmarionncern, @smoortga, @sethzenz, @JyothsnaKomaragiri, @makortel, @threus, @jhgoh, @amagitte, @apsallid, @jbsauvan, @cericeci, @dildick, @battibass, @pieterdavid, @forthommel, @vandreev11, @Sam-Harper, @HuguesBrun, @cbernet, @rovere, @VinInn, @cseez, @ferencek, @nhanvtran, @gkasieczka, @tocheng, @deguio, @schoef, @alesaggio, @mmusich, @ptcox, @abdoulline, @fabiocos, @clelange, @kreczko, @jdamgov, @jdolen, @rchatter, @trocino, @riga, @jan-kaspar, @wddgit, @calderona, @mverzett, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @amarini, @andrzejnovak, @folguera, @pfs this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2020-07-31T13:06:15Z

-1

Tested at: f9b0ef8

CMSSW: CMSSW_11_2_X_2020-07-31-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70fc35/8467/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency ClangBuild

Build:

I found compilation warning when building: See details on the summary page.

Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2020-07-31T13:06:17Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-08-01T08:44:46Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

Dr15Jones · 2020-08-01T12:26:18Z

So it looks like this is causing scram to find circular dependencies?

davidlange6 · 2020-08-01T13:12:03Z

I suspect as well. I’ll look more when back to a computer.... David On 1 Aug 2020, at 14:27, Chris Jones <[email protected]> wrote: So it looks like this is causing scram to find circular dependencies? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#31005 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQZ65IZ4WCPFLEJBQCLR6QCXTANCNFSM4PQF44EA>.

DataFormats/ParticleFlowReco/BuildFile.xml

Dr15Jones · 2020-08-01T16:19:33Z

The problem is a direct circular dependency between DataFormats/GeometrySurface and DataFormats/GeometryCommonDetAlgo. It looks like GeometrySurface was intended to be the 'lower level' package. Unfortunately it grew the following dependency

[cdj@cmslpc151 src]$ grep GeometryCommonDetAlgo $CMSSW_RELEASE_BASE/src/DataFormats/GeometrySurface/*/*
[cut]DataFormats/GeometrySurface/interface/LocalErrorBaseExtended.h:#include "DataFormats/GeometryCommonDetAlgo/interface/DeepCopyPointer.h"
[cut]/DataFormats/GeometrySurface/interface/LocalErrorExtended.h:#include "DataFormats/GeometryCommonDetAlgo/interface/ErrorMatrixTag.h"

The inclusion of DeepCopyPointer.h is unnecessary while ErrorMatrixTag is used. However, the definition of LocalErrorExtended is only used in two places

[cdj@cmslpc151 src]$ git grep DataFormats/GeometrySurface/interface/LocalErrorExtended.h
DataFormats/GeometryCommonDetAlgo/interface/ErrorFrameTransformer.h:#include "DataFormats/GeometrySurface/interface/LocalErrorExtended.h"
Geometry/CommonTopologies/interface/MuonGeomDet.h:#include "DataFormats/GeometrySurface/interface/LocalErrorExtended.h"

and

[cdj@cmslpc151 src]$ git grep DataFormats/GeometrySurface/interface/LocalErrorBaseExtended.h
DataFormats/GeometrySurface/interface/LocalErrorExtended.h:#include "DataFormats/GeometrySurface/interface/LocalErrorBaseExtended.h"

Therefore LocalErrorBaseExtended.h and LocalErrorExtended.h can easily be moved to DataFormats/GeometryCommonDetAlgo.

Co-authored-by: Chris Jones <[email protected]>

cmsbuild · 2020-08-01T17:57:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-01T18:03:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31005/17498

This PR adds an extra 64KB to repository

cmsbuild · 2020-08-01T18:04:15Z

Pull request #31005 was updated. @andrius-k, @ggovi, @christopheralanwest, @kpedro88, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @fwyzard, @smuzaffar, @Dr15Jones, @tocheng, @jfernan2, @mdhildreth, @slava77, @jpata, @benkrikler, @kmaeshima, @emeschi, @mommsen can you please check and sign again.

Dr15Jones · 2020-08-01T18:05:16Z

@davidlange6 I'm working on a pull request now to fix the geometry dependencies.

Dr15Jones · 2020-08-01T18:23:42Z

See #31018

davidlange6 · 2020-08-02T07:13:51Z

thanks @Dr15Jones - I see that there is at least one more circular dep to fix too:(

davidlange6 · 2020-08-02T07:30:02Z

ok - I close this - there are numerous circular dependencies revealed by this PR

makortel · 2020-08-03T14:49:09Z

Great - if you want to suggest a patch, I can apply it in this PR.

Could you cherry-pick this one makortel@7868841 ?

I'll make a separate PR of this then.

missing buildfile dependencies

f9b0ef8

cmsbuild added this to the CMSSW_11_2_X milestone Jul 31, 2020

cmsbuild added alca-pending analysis-pending code-checks-pending comparison-pending core-pending daq-pending db-pending dqm-pending hlt-pending l1-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Jul 31, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 31, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 31, 2020

cmsbuild removed the comparison-pending label Jul 31, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Aug 1, 2020

Dr15Jones suggested changes Aug 1, 2020

View reviewed changes

DataFormats/ParticleFlowReco/BuildFile.xml Outdated Show resolved Hide resolved

DataFormats/ParticleFlowReco/BuildFile.xml Outdated Show resolved Hide resolved

davidlange6 and others added 2 commits August 1, 2020 19:57

Update DataFormats/ParticleFlowReco/BuildFile.xml

69ea525

Co-authored-by: Chris Jones <[email protected]>

Update DataFormats/ParticleFlowReco/BuildFile.xml

02744e9

Co-authored-by: Chris Jones <[email protected]>

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-notrun tests-rejected labels Aug 1, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 1, 2020

davidlange6 closed this Aug 2, 2020

davidlange6 mentioned this pull request Aug 2, 2020

Circular dependencies in DataFormats #31019

Open

makortel mentioned this pull request Aug 3, 2020

Remove unnecessary includes to FWCore/ParameterSet #31025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

missing buildfile dependencies in DataFormats and CondFormats #31005

missing buildfile dependencies in DataFormats and CondFormats #31005

davidlange6 commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

davidlange6 commented Jul 31, 2020

cmsbuild commented Jul 31, 2020 •

edited

Loading

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Aug 1, 2020

Dr15Jones commented Aug 1, 2020

davidlange6 commented Aug 1, 2020 via email

Dr15Jones commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

Dr15Jones commented Aug 1, 2020

Dr15Jones commented Aug 1, 2020 •

edited

Loading

davidlange6 commented Aug 2, 2020

davidlange6 commented Aug 2, 2020

makortel commented Aug 3, 2020

missing buildfile dependencies in DataFormats and CondFormats #31005

missing buildfile dependencies in DataFormats and CondFormats #31005

Conversation

davidlange6 commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

davidlange6 commented Jul 31, 2020

cmsbuild commented Jul 31, 2020 • edited Loading

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Jul 31, 2020

cmsbuild commented Aug 1, 2020

Dr15Jones commented Aug 1, 2020

davidlange6 commented Aug 1, 2020 via email

Dr15Jones commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

Dr15Jones commented Aug 1, 2020

Dr15Jones commented Aug 1, 2020 • edited Loading

davidlange6 commented Aug 2, 2020

davidlange6 commented Aug 2, 2020

makortel commented Aug 3, 2020

cmsbuild commented Jul 31, 2020 •

edited

Loading

Dr15Jones commented Aug 1, 2020 •

edited

Loading