PFProducer fix for PFMuonAlgo's fillPSetDescription #30936

hatakeyamak · 2020-07-28T12:31:13Z

PR description:

Use the PFMuonAlgo's fillPSetDescription for PFMuonAlgo (instead of PFEGammaFilters's one). This was an oversight of the previous refactor work.
This fix was made based on the issue reported here: #30849.

Also, some functions of PFMuonAlgo were made static to simpler calls from GeneralTracksImporter(WithVeto).

PR validation:

Made sure it compiles. Also ran matrix test 10824.0 (2018 ttbar) and made sure that the output doesn't have any change.
Also tested with 11634.0 (ttbar 2021) and 23234.0 (ttbar 2026D49).

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport.

@bendavid @guitargeek

cmsbuild · 2020-07-28T12:31:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-28T12:39:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30936/17352

This PR adds an extra 20KB to repository

cmsbuild · 2020-07-28T12:39:28Z

A new Pull Request was created by @hatakeyamak (Kenichi Hatakeyama) for master.

It involves the following packages:

RecoParticleFlow/PFProducer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-07-28T13:15:45Z

@cmsbuild please test

cmsbuild · 2020-07-28T13:16:08Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-27-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8352/console Started: 2020/07/28 15:17

cmsbuild · 2020-07-28T14:17:30Z

-1

Tested at: 7b6b96f

CMSSW: CMSSW_11_2_X_2020-07-27-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-605595/8352/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

11634.0 step2

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

12434.0 step2

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-07-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Jul 28 16:07:09 2020-date Tue Jul 28 16:03:44 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Tue Jul 28 16:07:09 2020-date Tue Jul 28 16:03:44 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-07-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jul 28 16:10:49 2020-date Tue Jul 28 16:03:48 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Tue Jul 28 16:10:49 2020-date Tue Jul 28 16:03:48 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-07-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Jul 28 16:10:35 2020-date Tue Jul 28 16:04:01 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Tue Jul 28 16:10:35 2020-date Tue Jul 28 16:04:01 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-07-27-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Jul 28 16:09:52 2020-date Tue Jul 28 16:04:27 2020 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Tue Jul 28 16:09:52 2020-date Tue Jul 28 16:04:27 2020 s - exit: 18688

cmsbuild · 2020-07-28T14:17:32Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-08-01T19:51:37Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-01T19:57:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30936/17500

This PR adds an extra 40KB to repository

cmsbuild · 2020-08-01T19:57:48Z

Pull request #30936 was updated. @perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please check and sign again.

slava77 · 2020-08-02T02:43:58Z

@cmsbuild please test

cmsbuild · 2020-08-02T02:44:21Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-01-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8496/console Started: 2020/08/02 04:45

cmsbuild · 2020-08-02T03:54:47Z

+1
Tested at: 509309b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-605595/8496/summary.html
CMSSW: CMSSW_11_2_X_2020-08-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-02T03:54:50Z

Comparison job queued.

cmsbuild · 2020-08-02T05:19:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-605595/8496/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525448
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2525400
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

perrotta · 2020-08-03T15:49:48Z

+1

A wrongly asssigned PSet in the PFProducer code is here correctly changed to the PFMuonAlgo one, as it should
That wrongly assigned PSet was ineffective to the previous code, because of automatic switches to the default parameter: during the review, and in the associated github issue PFMuonAlgo configuration #30849, it was pointed out that such a replacement was not safe in case one really wanted to assign new parameters and by mistake some wrong one is also supplied
The latest commits in this PR address that issue, which looks like being solved here
Jenkins tests pass and show no differences, as they should

Martin-Grunewald · 2020-08-04T11:43:18Z

+1

cmsbuild · 2020-08-04T11:43:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-08-04T14:19:59Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jul 28, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 28, 2020

hatakeyamak changed the title ~~Pf producer fix for pf muon algo fill p set description~~ PFProducer fix for PFMuonAlgo's fillPSetDescription Jul 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 28, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 28, 2020

cmsbuild added comparison-notrun tests-rejected code-checks-pending comparison-pending hlt-pending tests-pending and removed comparison-pending tests-started code-checks-approved comparison-notrun tests-rejected labels Jul 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 1, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 2, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 2, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 2, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 3, 2020

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Aug 4, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 4, 2020

cmsbuild merged commit 10852c8 into cms-sw:master Aug 4, 2020

guitargeek mentioned this pull request Aug 4, 2020

PFMuonAlgo configuration #30849

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PFProducer fix for PFMuonAlgo's fillPSetDescription #30936

PFProducer fix for PFMuonAlgo's fillPSetDescription #30936

hatakeyamak commented Jul 28, 2020 •

edited

Loading

cmsbuild commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

slava77 commented Jul 28, 2020

cmsbuild commented Jul 28, 2020 •

edited

Loading

cmsbuild commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

slava77 commented Aug 2, 2020

cmsbuild commented Aug 2, 2020 •

edited

Loading

cmsbuild commented Aug 2, 2020

cmsbuild commented Aug 2, 2020

cmsbuild commented Aug 2, 2020

perrotta commented Aug 3, 2020

Martin-Grunewald commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

silviodonato commented Aug 4, 2020

PFProducer fix for PFMuonAlgo's fillPSetDescription #30936

PFProducer fix for PFMuonAlgo's fillPSetDescription #30936

Conversation

hatakeyamak commented Jul 28, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

slava77 commented Jul 28, 2020

cmsbuild commented Jul 28, 2020 • edited Loading

cmsbuild commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

cmsbuild commented Aug 1, 2020

slava77 commented Aug 2, 2020

cmsbuild commented Aug 2, 2020 • edited Loading

cmsbuild commented Aug 2, 2020

cmsbuild commented Aug 2, 2020

cmsbuild commented Aug 2, 2020

perrotta commented Aug 3, 2020

Martin-Grunewald commented Aug 4, 2020

cmsbuild commented Aug 4, 2020

silviodonato commented Aug 4, 2020

hatakeyamak commented Jul 28, 2020 •

edited

Loading

cmsbuild commented Jul 28, 2020 •

edited

Loading

cmsbuild commented Aug 2, 2020 •

edited

Loading