-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed use of boost::mpl::vector for dependent Records #30874
Conversation
boost::mpl implementation was found to be very heavy weight and was causing difficulties with attempts to use ROOT's module system. As the use of mpl was fairly simple in the DependentRecord system it was replaced with our own edm::mpl::Vector code.
The code-checks are being triggered in jenkins. |
@davidlange6 FYI |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30874/17245
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CalibCalorimetry/EcalLaserCorrection @ggovi, @lveldere, @sbein, @ianna, @kpedro88, @rekovic, @tlampen, @pohsun, @santocch, @perrotta, @civanch, @makortel, @cmsbuild, @smuzaffar, @Dr15Jones, @cvuosalo, @ssekmen, @mdhildreth, @tocheng, @slava77, @jpata, @benkrikler, @christopheralanwest, @alja can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
The tests are being triggered in jenkins.
|
+1 |
Do you have any objections? |
+1 |
merge |
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
Update dependent records declarations to use edm::mpl::Vector instead of boost::mpl::vector, following cms-sw#30874.
PR description:
Replace the use of boost::mpl::vector with our own edm::mpl::Vector class. The implementation is fairly simple when using C++17 features.
This change was based on a discussion at the Core meeting about the difficulties with boost mpl with respect to generating ROOT modules.
PR validation:
The code compiles and framework unit tests pass.