-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx256 Try to provide V14 geometry for HGCal #30862
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30862/17219
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30862/17220
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/CaloTopology @kmaeshima, @andrius-k, @Dr15Jones, @makortel, @cvuosalo, @schneiml, @benkrikler, @mdhildreth, @ianna, @cmsbuild, @rekovic, @jfernan2, @fioriNTU, @civanch, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+upgrade |
+1 |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
First phase to go for V14 geometry of HGCal
PR validation:
Tested using runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special