Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to std::filesystem #30825

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

camolezi
Copy link
Contributor

@camolezi camolezi commented Jul 18, 2020

PR description:

Boost and std filesystem have similar functionality. When possible we should use std::filesystem to avoid unnecessary dependencies.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

boost and std filesystem have similar functionality. When possible we should use std::filesystem to avoid unnecessary dependencies
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30825/17164

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

DataFormats/OnlineMetaData
IORawData/CaloPatterns
L1TriggerConfig/L1GtConfigProducers

@perrotta, @benkrikler, @emeschi, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @mommsen, @tlampen, @jpata, @pohsun can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @rovere, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 18, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: bee8aa9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a951fd/8104/summary.html
CMSSW: CMSSW_11_2_X_2020-07-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a951fd/8104/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525996
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525948
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@mommsen
Copy link
Contributor

mommsen commented Jul 19, 2020

+1

@jpata
Copy link
Contributor

jpata commented Jul 21, 2020

+1

  • tests pass with no differences in reco, as expected
  • changes are technical and in line with the description

@pohsun
Copy link

pohsun commented Jul 24, 2020

+1

@silviodonato
Copy link
Contributor

merge
@rekovic technical fix

@rekovic
Copy link
Contributor

rekovic commented Jul 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants