Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boost dependency from GeneratorInterface/LHEInterface #30816

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

camolezi
Copy link
Contributor

@camolezi camolezi commented Jul 17, 2020

PR description:

  • C++17 std::filesystem is very similar to boost::filesystem. There is no reason to use boost::filesystem in this case, when std::filesystem could be used
  • We can delete the copy constructor and copy assignment operator instead of using boost::noncopyable
  • In this case we don't need boost::ptr_deque. Its possible to use std::deque< std::unique_ptr > without a loss in readability

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

camolezi added 3 commits July 17, 2020 21:30
C++17 std::filesystem is very similar to boost::filesystem. There is no reason to use boost::filesystem here, when std::filesystem could be used
We can delete the copy constructor and copy assignment operator instead of using boost::noncopyable
In this case we don't need boost::ptr_deque. Its possible to use std::deque<std::unique_ptr> without a loss in readability
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30816/17152

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

GeneratorInterface/LHEInterface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Jul 18, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7fdc00a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0b5e0/8098/summary.html
CMSSW: CMSSW_11_2_X_2020-07-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0b5e0/8098/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525996
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525948
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@SiewYan
Copy link
Contributor

SiewYan commented Jul 21, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants