-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove boost dependency from GeneratorInterface/LHEInterface #30816
Remove boost dependency from GeneratorInterface/LHEInterface #30816
Conversation
C++17 std::filesystem is very similar to boost::filesystem. There is no reason to use boost::filesystem here, when std::filesystem could be used
We can delete the copy constructor and copy assignment operator instead of using boost::noncopyable
In this case we don't need boost::ptr_deque. Its possible to use std::deque<std::unique_ptr> without a loss in readability
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30816/17152
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: GeneratorInterface/LHEInterface @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR validation:
Passed on basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6