[HGCal] Shrinking Layer Clustering internal data structures - backport to 11_1_X

[felicepantaleo]

PR description:

backport to 11_1_X of #30753

[cmsbuild]

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for CMSSW_11_1_X.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers

@perrotta, @jpata, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @deguio, @sethzenz, @riga, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

• Backported from [HGCal] Shrinking Layer Clustering internal data structures #30753

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-07-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8018/console Started: 2020/07/16 18:26

[cmsbuild]

+1
Tested at: a287b79
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c98e4/8018/summary.html
CMSSW: CMSSW_11_1_X_2020-07-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c98e4/8018/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780740
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cmsbuild]

Pull request #30757 was updated. @perrotta, @jpata, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-07-17-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8058/console Started: 2020/07/17 16:43

[cmsbuild]

+1
Tested at: 0295d4f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c98e4/8058/summary.html
CMSSW: CMSSW_11_1_X_2020-07-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[slava77]

backport of #30753

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c98e4/8058/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780739
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

+1

for #30757 0295d4f

• changes in the code are the same as in [HGCal] Shrinking Layer Clustering internal data structures #30753
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

This is a technical update, just cleaning up some memory hoarding (or/and for-peak allocation)

[srimanob]

@silviodonato @slava77
I've done the test on full prod-like reco sequence, seems we are at 14 GB now which is a good sign.

[srimanob]

@silviodonato
As mentioned in email "Converging on HLT TDR Production", please feel free to build the release. We will then can set the pilot from the new release. Thanks.

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1