Move GEMDigi dictionary generating classes #30740

watson-ij · 2020-07-16T05:56:48Z

PR description:

Move GEMDigi dictionary generating classes from EventFilter/GEMRawToDigi to DataFormats/GEMDigi and update references

Per issue #30586 only DataFormats should have objects generating dictionaries.

PR validation:

Checked upgrade workflow 11621.0 still completes successfully with the changes. Grep'd through cmssw for references to the moved objects, and ran code-checks.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

…ataFormats/GEMDigi and update references

cmsbuild · 2020-07-16T05:57:17Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-16T06:03:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30740/17058

This PR adds an extra 32KB to repository

cmsbuild · 2020-07-16T06:03:46Z

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

DQM/GEM
DataFormats/GEMDigi
EventFilter/GEMRawToDigi

@perrotta, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @jpata, @kpedro88 can you please review it and eventually sign? Thanks.
@jshlee, @Martin-Grunewald, @dildick, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-07-16T06:14:29Z

please test

cmsbuild · 2020-07-16T06:14:54Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-15-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7998/console Started: 2020/07/16 11:07

cmsbuild · 2020-07-16T10:18:32Z

+1
Tested at: 82e0697
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6335d8/7998/summary.html
CMSSW: CMSSW_11_2_X_2020-07-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-16T10:18:35Z

Comparison job queued.

cmsbuild · 2020-07-16T13:29:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6335d8/7998/summary.html

Comparison Summary:

You potentially added 672 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612943
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2612894
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 146 log files, 17 edm output root files, 35 DQM output files

jfernan2 · 2020-07-16T14:16:35Z

@watson-ij there seems to be erros due to duplicated dictionaries:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6335d8/7998/dupDict/

watson-ij · 2020-07-16T14:48:24Z

@watson-ij there seems to be erros due to duplicated dictionaries:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6335d8/7998/dupDict/

So, the classes.h and classes_def.xml in EventFilter is deleted with this PR, and those classes are moved into the DataFormats. But it looks like the EventFilter classes_def is still being picked up in the Jenkins build? Not sure if theres a way around that?

cmsbuild · 2020-07-17T06:49:55Z

Pull request #30740 was updated. @perrotta, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @jpata, @kpedro88 can you please check and sign again.

perrotta · 2020-07-17T07:02:45Z

please test with cms-sw/cmsdist#6090

cmsbuild · 2020-07-17T07:03:05Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#6090
Test Parameters:

BUILD_FULL_CMSSW = true
CMSSW_11_2_X_2020-07-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8040/console Started: 2020/07/17 09:36

cmsbuild · 2020-07-17T15:45:00Z

-1

Tested at: 1823c7f

CMSSW: CMSSW_11_2_X_2020-07-16-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c9976/8040/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test TestConfigDP had ERRORS
---> test TestDQMOfflineConfiguration100 had ERRORS
---> test TestDQMOfflineConfiguration200 had ERRORS
---> test materialBudgetTrackerPlots had ERRORS
---> test TestDQMOfflineConfiguration0 had ERRORS
---> test TestDQMOfflineConfiguration150 had ERRORS
---> test TestDQMOfflineConfiguration50 had ERRORS

cmsbuild · 2020-07-17T15:45:05Z

Comparison job queued.

cmsbuild · 2020-07-17T17:34:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c9976/8040/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2612943
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2612894
DQMHistoTests: Total skipped: 48
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 146 log files, 17 edm output root files, 35 DQM output files

slava77 · 2020-07-17T19:11:23Z

+1

for #30740 1823c7f

code changes are in line with the PR description and the follow up review
- the data formats moved from EventFilter/GEMRawToDigi were apparently only lightly reviewed, quite likely due to originally more internal need for these classes. Style should be followed better for the centrally distributed DataFormats. Some cleanup/update for non-persisted types, members, and methods would be useful, to follow http://cms-sw.github.io/cms_coding_rules.html#2--naming-rules-1. @jshlee @watson-ij please take a note for a to-do list.
jenkins tests pass and comparisons with the baseline show no differences
- unit test failures are not related to this PR

slava77 · 2020-07-20T14:25:04Z

dqm, simulation, and upgrade signatures are still needed here.
Please check.

kpedro88 · 2020-07-20T14:36:31Z

+upgrade

jfernan2 · 2020-07-20T16:30:39Z

+1

silviodonato · 2020-07-21T16:51:16Z

merge

watson-ij added 2 commits July 16, 2020 14:28

Move dictionary generating classes from EventFilter/GEMRawToDigi to D…

2b6858f

…ataFormats/GEMDigi and update references

Fix some header paths

82e0697

cmsbuild added this to the CMSSW_11_2_X milestone Jul 16, 2020

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Jul 16, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 16, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 16, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 16, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 16, 2020

cmsbuild mentioned this pull request Jul 17, 2020

[Do not merge] Just for PR tests cms-sw/cmsdist#6090

Closed

cmsbuild added requires-external tests-started and removed tests-pending labels Jul 17, 2020

cmsbuild added tests-rejected and removed tests-started labels Jul 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 17, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 17, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 20, 2020

cmsbuild added dqm-approved and removed dqm-pending labels Jul 20, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 21, 2020

cmsbuild merged commit 9886f0c into cms-sw:master Jul 21, 2020

cmsbuild mentioned this pull request Jul 21, 2020

[Test Only] DQM: Reduce size of he[ef]RecVsSimZ. #30854

Closed

perrotta mentioned this pull request Aug 1, 2020

Duplicate GEMVfatStatusDigi in cmssw #30586

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move GEMDigi dictionary generating classes #30740

Move GEMDigi dictionary generating classes #30740

watson-ij commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

perrotta commented Jul 16, 2020

cmsbuild commented Jul 16, 2020 •

edited

Loading

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

jfernan2 commented Jul 16, 2020

watson-ij commented Jul 16, 2020

cmsbuild commented Jul 17, 2020

perrotta commented Jul 17, 2020

cmsbuild commented Jul 17, 2020 •

edited

Loading

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

slava77 commented Jul 17, 2020 •

edited

Loading

slava77 commented Jul 20, 2020

kpedro88 commented Jul 20, 2020

jfernan2 commented Jul 20, 2020

silviodonato commented Jul 21, 2020

Move GEMDigi dictionary generating classes #30740

Move GEMDigi dictionary generating classes #30740

Conversation

watson-ij commented Jul 16, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

perrotta commented Jul 16, 2020

cmsbuild commented Jul 16, 2020 • edited Loading

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

cmsbuild commented Jul 16, 2020

jfernan2 commented Jul 16, 2020

watson-ij commented Jul 16, 2020

cmsbuild commented Jul 17, 2020

perrotta commented Jul 17, 2020

cmsbuild commented Jul 17, 2020 • edited Loading

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

cmsbuild commented Jul 17, 2020

slava77 commented Jul 17, 2020 • edited Loading

slava77 commented Jul 20, 2020

kpedro88 commented Jul 20, 2020

jfernan2 commented Jul 20, 2020

silviodonato commented Jul 21, 2020

cmsbuild commented Jul 16, 2020 •

edited

Loading

cmsbuild commented Jul 17, 2020 •

edited

Loading

slava77 commented Jul 17, 2020 •

edited

Loading