Use dxy sign of GSF track instead of IPTools for pat::Electron

[afiqaize]

PR description:

Propagate the dxy sign fix for muons (#28753) to electrons as well.

PR validation:

Made nAODs from a bb4l AOD samples (~6k events) before and after the code change, verified that only dxy sign changed.

A backport to 106X ala #29537 can be made if needed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30738/17050

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30738/17050/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30738/17050/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30738/17052

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @afiqaize (Afiq Anuar) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7993/console Started: 2020/07/16 03:27

[cmsbuild]

+1
Tested at: ed53a82
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a02976/7993/summary.html
CMSSW: CMSSW_11_2_X_2020-07-15-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a02976/7993/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612943
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612888
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 146 log files, 17 edm output root files, 35 DQM output files

[santocch]

+1

[perrotta]

+1

• The code changes are in line with the PR description and completely similar to those already integrated for muons with Fixed sign in pat::Muon::dB() to match one obtained from the best track definition  #28753
• Jenkins tests pass and show differences only in electron dxy and its error in nanoAOD

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[perrotta]

@afiqaize @SohamBhattacharya : do you plan to backport this to 10_6_X (similarly to what was done for the muons with #29537)? Please let us know, and prepare a backport PR at your earliest convenience if needed

[afiqaize]

@perrotta yes we plan to do so. The PR will come today.