Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clang tidy] Apply checks for geometry-upgrade #30722

Closed
wants to merge 1 commit into from
Closed

[Clang tidy] Apply checks for geometry-upgrade #30722

wants to merge 1 commit into from

Conversation

cmsbuild
Copy link
Contributor

Apply new clang checks. See #30508 for more info.

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jul 15, 2020
@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30722/17024

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Geometry/GEMGeometryBuilder
Geometry/MTDCommonData
Geometry/MTDGeometryBuilder
Geometry/MTDNumberingBuilder
SLHCUpgradeSimulations/Geometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@jshlee, @dildick, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

kpedro88
kpedro88 reviewed Jul 15, 2020
View reviewed changes
SLHCUpgradeSimulations/Geometry/test/phase2_digi_reco_pixelntuple_cfg.py
@@ -6,8 +6,8 @@
import FWCore.ParameterSet.Config as cms


from Configuration.Eras.Era_Phase2C9_cff import Phase2C9
process = cms.Process('Phase2PixelNtuple',Phase2C9)
from Configuration.Eras.Era_Phase2C8_cff import Phase2C8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change in this file and the file below constitute a regression
please remake this PR on the latest IB

@cmsbuild cmsbuild closed this Jul 17, 2020
@cmsbuild cmsbuild deleted the apply-new-ct-checks-for-geometry-upgrade branch July 17, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpedro88 kpedro88 kpedro88 left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.
2 participants
@cmsbuild @kpedro88