Fix out-of-bound issue in call to LUT in GEM-CSC trigger [11_1_X]

[dildick]

PR description:

• This PR should fix a bug reported in the GEM-CSC trigger in CMSSW_11_0_X samples, when a pad number goes out of bounds in the [] operator. I also replaced [] with at() and added a few assert statements. The bug was introduced when the pad numbering in GE1/1 was changed from 1->192 to 0->191, and in GE2/1 from 1->384 to 0->383. Messages like the one below must not appear any more

%MSG-w L1T:  L1TMuonEndCapTrackProducer:simEmtfDigis 19-Jun-2020 08:46:45 CEST  Run: 1 Event: 41297689
EMTF CSC format error in station 1, ring 1: tp_data.keywire = 561 (max = 47)
%MSG

• Clear copad vector in the copad processor for each new event. As explained here (GE2/1 pads with 16 eta partitions & option to send overflow GEM clusters #30169 (comment)) there should be a reduction in the number of coincidence GEM pads in the comparisons.

PR validation:

Tested on a few thousand events in /Mu_FlatPt2to100-pythia8-gun/PhaseIITDRSpring19DR-PU200_106X_upgrade2023_realistic_v3-v2/GEN-SIM-DIGI-RAW

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #30564. Partial backport of #30169 (50a2b7f) needed for HLT TDR reprocessing.

FYI @eyigitba @tahuang1991 @rekovic

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_11_1_X.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-07-08-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7819/console Started: 2020/07/09 12:59

[silviodonato]

urgent

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 95593e6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-022d7a/7819/summary.html
CMSSW: CMSSW_11_1_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[silviodonato]

merge

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-022d7a/7819/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780722
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files