Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More L1T bug fixes #30606

Merged
merged 4 commits into from
Jul 9, 2020
Merged

More L1T bug fixes #30606

merged 4 commits into from
Jul 9, 2020

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Jul 8, 2020

PR description:

Fix several bugs found by @tommasoboccali.

PR validation:

Tested compilation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30606/16865

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30606/16866

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

DataFormats/L1Trigger
L1Trigger/Configuration
L1Trigger/L1CaloTrigger

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 8, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2020

The tests are being triggered in jenkins.

@fwyzard
Copy link
Contributor

fwyzard commented Jul 9, 2020

type bugfix

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit dd4537b into cms-sw:master Jul 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

+1
Tested at: 6563ceb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35434f/7817/summary.html
CMSSW: CMSSW_11_2_X_2020-07-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35434f/7817/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787364
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787313
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jul 9, 2020

+upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants