Refactoring of anti-electron tauID

[mbluj]

PR description:

In this development code of the anti-electron tauID is refactored as follows:

1. Tau and electron type specific versions of the anti-e tauID producer (TauDiscriminationAgainstElectronMVA6) and an algorithm executed by the producer (AntiElectronIDMVA6) are merged each into one template version;
2. Code rationalization and cleaning preformed;
3. Explicit cfi configuration files replaced by auto-generated ones.

Modifications introduced in this PR are purely technical and therefore are expected that they do not change output of the modified anti-electron tauID.

PR validation:

Matrix tests (runTheMatrix.py -l limited -i all --ibeos) successful.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30581/16818

• This PR adds an extra 52KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): Add new MVA tau ID for phase II #30341
  • File RecoTauTag/RecoTau/src/AntiElectronIDMVA6.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

PhysicsTools/NanoAOD
RecoTauTag/Configuration
RecoTauTag/RecoTau

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc, @riga this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-07-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7767/console Started: 2020/07/07 20:44

[cmsbuild]

+1
Tested at: aff43e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed053c/7767/summary.html
CMSSW: CMSSW_11_2_X_2020-07-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed053c/7767/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2787364
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2787308
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 154 log files, 17 edm output root files, 37 DQM output files

[cmsbuild]

Pull request #30581 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-07-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8019/console Started: 2020/07/16 18:39

[cmsbuild]

+1
Tested at: aa84916
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed053c/8019/summary.html
CMSSW: CMSSW_11_2_X_2020-07-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed053c/8019/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2612943
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2612894
• DQMHistoTests: Total skipped: 48
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 146 log files, 17 edm output root files, 35 DQM output files

[perrotta]

+1

• Code refactoring with template version of the producer, as in the PR description
• Jenkins tests pass and show no differences in outputs, as it should
• Timing also not affected

[mariadalfonso]

+1
changes in PhysicsTools/NanoAOD/python/taus_updatedMVAIds_cff.py follows templating changes

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1