-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce boost dependency in CondCore/CondDB #30580
Reduce boost dependency in CondCore/CondDB #30580
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30580/16815
|
A new Pull Request was created by @camolezi (Lucas Camolezi) for master. It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test
On 7 Jul 2020, at 19:51, cmsbuild <[email protected]> wrote:
A new Pull Request was created by @camolezi<https://github.com/camolezi> (Lucas Camolezi) for master.
It involves the following packages:
CondCore/CondDB
@ggovi<https://github.com/ggovi>, @cmsbuild<https://github.com/cmsbuild> can you please review it and eventually sign? Thanks.
@mmusich<https://github.com/mmusich> this is something you requested to watch as well.
@silviodonato<https://github.com/silviodonato>, @dpiparo<https://github.com/dpiparo> you are the release manager for this.
cms-bot commands are listed here<http://cms-sw.github.io/cms-bot-cmssw-cmds.html>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#30580 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ5DB36IFVRTSU3X6RTR2NN7TANCNFSM4OTERMUQ>.
|
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Replaced boost filesystem for std filesystem.
The code should have the same behaviour.
PR validation:
Passed on basic runTheMatrix test.
if this PR is a backport please specify the original PR and why you need to backport that PR:
@vgvassilev @davidlange6