added esConsumes to modules in RecoMET/METProducers #30562

JamminJones · 2020-07-06T19:05:20Z

PR description:

added esConsumes to 7 modules

PR validation:

the code compiles

cmsbuild · 2020-07-06T19:05:42Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2020-07-06T19:07:24Z

The code was changed under my supervision.

cmsbuild · 2020-07-06T19:11:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30562/16798

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMET/METProducers/interface/MuonTCMETValueMapProducer.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File RecoMET/METProducers/src/HcalNoiseInfoProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File RecoMET/METProducers/src/MuonTCMETValueMapProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-07-06T19:12:05Z

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

RecoMET/METProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-07-06T19:19:16Z

please test

cmsbuild · 2020-07-06T19:19:42Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-06-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7721/console Started: 2020/07/06 21:20

perrotta · 2020-07-06T19:52:20Z

RecoMET/METProducers/src/HcalNoiseInfoProducer.cc

 #include "DataFormats/METReco/interface/HcalCaloFlagLabels.h"
 #include "DataFormats/HcalRecHit/interface/HBHERecHitAuxSetter.h"
 #include "DataFormats/HcalRecHit/interface/CaloRecHitAuxSetter.h"
-#include "Geometry/CaloGeometry/interface/CaloGeometry.h"
-#include "Geometry/Records/interface/CaloGeometryRecord.h"
 #include "Geometry/Records/interface/HcalRecNumberingRecord.h"


Already in the header

cmsbuild · 2020-07-06T20:38:26Z

+1
Tested at: f187488
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1453b2/7721/summary.html
CMSSW: CMSSW_11_2_X_2020-07-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-06T20:38:28Z

Comparison job queued.

cmsbuild · 2020-07-06T22:25:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1453b2/7721/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787364
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2787308
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
Checked 154 log files, 17 edm output root files, 37 DQM output files

perrotta · 2020-07-09T07:39:17Z

@JamminJones please let us know whether you plan to fix the duplicate inclusion of HcalRecNumberingRecord.h, reported in #30562 (review)

JamminJones · 2020-07-09T14:01:56Z

@perrotta I am sorry that I did not see this until now but I will fix the duplicate inclusion right away

cmsbuild · 2020-07-09T14:09:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-07-09T14:15:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30562/16880

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMET/METProducers/interface/MuonTCMETValueMapProducer.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
- File RecoMET/METProducers/src/HcalNoiseInfoProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoMET/METProducers/src/MuonTCMETValueMapProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-loop-convert #29935

cmsbuild · 2020-07-09T14:15:55Z

Pull request #30562 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

Dr15Jones · 2020-07-09T15:42:54Z

please test

cmsbuild · 2020-07-09T15:43:20Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-09-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7827/console Started: 2020/07/09 20:42

cmsbuild · 2020-07-09T19:59:26Z

+1
Tested at: 19aab4c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1453b2/7827/summary.html
CMSSW: CMSSW_11_2_X_2020-07-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-09T19:59:28Z

Comparison job queued.

cmsbuild · 2020-07-09T21:57:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1453b2/7827/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2787429
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2787378
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 154 log files, 17 edm output root files, 37 DQM output files

perrotta · 2020-07-10T05:38:21Z

+1

Technical
Jenkinst tests pass

cmsbuild · 2020-07-10T05:38:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-10T07:54:57Z

+1

added esConsumes to modules in RecoMET/METProducers

f187488

cmsbuild added this to the CMSSW_11_2_X milestone Jul 6, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 6, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 6, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 6, 2020

perrotta reviewed Jul 6, 2020

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Jul 6, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 6, 2020

removed include of HCalNumberingRecord.h that was already in the h file

19aab4c

cmsbuild removed the code-checks-approved label Jul 9, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending labels Jul 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 9, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 9, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 9, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 9, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 10, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 10, 2020

cmsbuild merged commit 8e3cc9a into cms-sw:master Jul 10, 2020

JamminJones deleted the fixRecoMETMETProducers branch July 27, 2020 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added esConsumes to modules in RecoMET/METProducers #30562

added esConsumes to modules in RecoMET/METProducers #30562

JamminJones commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

Dr15Jones commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

Dr15Jones commented Jul 6, 2020

cmsbuild commented Jul 6, 2020 •

edited

Loading

perrotta Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

perrotta commented Jul 9, 2020

JamminJones commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

Dr15Jones commented Jul 9, 2020

cmsbuild commented Jul 9, 2020 •

edited

Loading

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

perrotta commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 10, 2020

added esConsumes to modules in RecoMET/METProducers #30562

added esConsumes to modules in RecoMET/METProducers #30562

Conversation

JamminJones commented Jul 6, 2020

PR description:

PR validation:

cmsbuild commented Jul 6, 2020

Dr15Jones commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

Dr15Jones commented Jul 6, 2020

cmsbuild commented Jul 6, 2020 • edited Loading

perrotta Jul 6, 2020

Choose a reason for hiding this comment

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

cmsbuild commented Jul 6, 2020

perrotta commented Jul 9, 2020

JamminJones commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

Dr15Jones commented Jul 9, 2020

cmsbuild commented Jul 9, 2020 • edited Loading

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

cmsbuild commented Jul 9, 2020

perrotta commented Jul 10, 2020

cmsbuild commented Jul 10, 2020

silviodonato commented Jul 10, 2020

cmsbuild commented Jul 6, 2020 •

edited

Loading

cmsbuild commented Jul 9, 2020 •

edited

Loading