Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase2 L1 ParticleFlow (11_1 backport) #30523

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Phase2 L1 ParticleFlow (11_1 backport) #30523

merged 2 commits into from
Jul 3, 2020

Conversation

silviodonato
Copy link
Contributor

Backport of #30510
(excluding L1Trigger/Configuration/python/SimL1Emulator_cff.py to avoid conflict with #30520)

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Jul 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited
Loading

A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_11_1_X.

It involves the following packages:

DataFormats/L1Trigger
L1Trigger/Phase2L1ParticleFlow

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test with #30520,#30519,#30517,#30515,#30516,cms-sw/cmsdist#6024

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #30520,#30519,#30517,#30515,#30516,cms-sw/cmsdist#6024

This was referenced Jul 3, 2020
Closed
Closed
Closed
Merged
Merged
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

-1
@silviodonato This pull request cannot be automatically merged, could you please rebase it?

You can see the log for git cms-merge-topic here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30523/7652/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Pull request #30523 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again.

@silviodonato silviodonato mentioned this pull request Jul 3, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #30531

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #30531

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #30531,#30511

@cmsbuild cmsbuild mentioned this pull request Jul 3, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

-1

Tested at: ca0c5bc

CMSSW: CMSSW_11_1_X_2020-07-03-1200
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2040c/7674/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log
23234.0 step2 
runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #30531

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit dea2cdd into cms-sw:CMSSW_11_1_X Jul 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

-1

Tested at: ca0c5bc

CMSSW: CMSSW_11_1_X_2020-07-03-1200
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-517c1c/7677/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #30511,#30516,cms-sw/cmsdist#6024,#30531

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2020

-1

Tested at: ca0c5bc

CMSSW: CMSSW_11_1_X_2020-07-03-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b4bd/7684/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2020

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-notrun l1-pending orp-approved pending-signatures requires-external tests-rejected upgrade-pending
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.
2 participants
@silviodonato @cmsbuild