-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move L1TrackTrigger step before L1 step #30480
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30480/16646
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Configuration/PyReleaseValidation @kmaeshima, @andrius-k, @Dr15Jones, @chayanit, @cvuosalo, @wajidalikhan, @schneiml, @ianna, @mdhildreth, @cmsbuild, @makortel, @jfernan2, @fioriNTU, @civanch, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
+1 |
merge |
+1 |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Since the
L1
step will include both L1 particle flow and L1 track match, we need to runL1TrackTrigger
beforeL1
.This PR makes this fix, and propagate this also to
Validation/Geometry/test/runMaterialDumpAnalyser_PhaseII.sh
(found with from a simple query on LXR https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_11_2_X_2020-06-28-2300&_filestring=&_string=%5C%2CL1TrackTrigger )PR validation:
runTheMatrix.py -l 21234.0,23234.0,20434.0,20034.0
works