Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move L1TrackTrigger step before L1 step #30480

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

silviodonato
Copy link
Contributor

PR description:

Since the L1 step will include both L1 particle flow and L1 track match, we need to run L1TrackTrigger before L1.
This PR makes this fix, and propagate this also to Validation/Geometry/test/runMaterialDumpAnalyser_PhaseII.sh (found with from a simple query on LXR https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_11_2_X_2020-06-28-2300&_filestring=&_string=%5C%2CL1TrackTrigger )

PR validation:

runTheMatrix.py -l 21234.0,23234.0,20434.0,20034.0 works

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

@rekovic
@kpedro88

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30480/16646

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/PyReleaseValidation
Validation/Geometry

@kmaeshima, @andrius-k, @Dr15Jones, @chayanit, @cvuosalo, @wajidalikhan, @schneiml, @ianna, @mdhildreth, @cmsbuild, @makortel, @jfernan2, @fioriNTU, @civanch, @pgunnell, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @rovere, @Martin-Grunewald, @apsallid, @lecriste, @rishabhCMS, @fabiocos, @slomeo, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

+1
Tested at: 4312f2b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9ab51/7549/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

Comparison job queued.

@chayanit
Copy link

chayanit commented Jul 1, 2020

+1

@silviodonato
Copy link
Contributor Author

merge

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 1, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9ab51/7549/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2784120
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2784064
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Jul 1, 2020

+upgrade

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 1, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants