-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all direct deps to BuildFile for FastSimDataFormats/External #30388
Add all direct deps to BuildFile for FastSimDataFormats/External #30388
Conversation
The code-checks are being triggered in jenkins. |
The meta issue #15248 tracks the C++ modules-related work. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30388/16451
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FastSimDataFormats/External @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
for all packages that still should be made into cxx modules (well, current list of them). Additions made by looking for packages directly included in interface or src.