Add direct deps to BuildFile for SimTracker/TrackerHitAssociation

[davidlange6]

for all packages that still should be made into modules (well, current list of them). Additions made by looking for packages directly included in interface or src

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30367/16430

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @wmtford, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[vgvassilev]

The meta issue #15248 tracks the C++ modules-related work.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-25-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7403/console Started: 2020/06/25 19:19

[cmsbuild]

+1
Tested at: e4648bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85755/7403/summary.html
CMSSW: CMSSW_11_2_X_2020-06-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d85755/7403/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778861
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[civanch]

+1

@davidlange6 , @vgvassilev , what about BuildFiles in tests ?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

I’m happy to send you my script if you’d like. I didn’t want to make my exercise more complex than it already was... On Jun 26, 2020, at 4:07 PM, Vladimir Ivantchenko <[email protected]<mailto:[email protected]>> wrote: +1 @davidlange6<https://github.com/davidlange6> , @vgvassilev<https://github.com/vgvassilev> , what about BuildFiles in tests ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#30367 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQYFOEACHCWPPQVSVJ3RYSTTHANCNFSM4OIMLJPQ>.

[silviodonato]

+1

[davidlange6]

On Jun 26, 2020, at 4:44 PM, David Lange ***@***.***> wrote: I’m happy to send you my script if you’d like. I didn’t want to make my exercise more complex than it already was...

However, I realize that test directories are quite a bit more complex than interface or src…

[smuzaffar]

I think we only need to fix the package level BuildFiles. bin, test and plugins are not directly use by other packages so no need to fix them