-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new modules for GEM offline DQM #30365
Add new modules for GEM offline DQM #30365
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30365/16422
|
A new Pull Request was created by @seungjin-yang for master. It involves the following packages: DQMOffline/Muon @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
New commits remove a deprecated gemEfficiencyHarvesterLoose from gemEfficiencyHarvesterSeq and unnecessary comments. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30365/16429
|
Pull request #30365 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
looks like this created problems in the IB - should it be reverted before 1100? |
PR description:
GEMOfflineMonitor checks the attributes of GEM-related objects like digi and rechit excluding what online DQM do. Segment part is planned to be updated after GEM/ME0 merging.
GEMEfficiencyAnalyzer and GEMEfficiiencyHarvester measure GEM efficiency and resolution using both tight global muons and standalone muons.
PR validation:
This PR was tested with workflow 11611.0 and 27411.0.
Plots can be found in he following two links.
https://indico.cern.ch/event/927191/contributions/3898232/attachments/2053764/3443071/Talk_GEM_DPG_200609_Offline_DQM.pdf
https://indico.cern.ch/event/931844/contributions/3916126/attachments/2062310/3459906/GEM_DPG_200623_Offline_DQM.pdf
@jshlee @watson-ij