Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new modules for GEM offline DQM #30365

Merged

Conversation

seungjin-yang
Copy link
Contributor

PR description:

GEMOfflineMonitor checks the attributes of GEM-related objects like digi and rechit excluding what online DQM do. Segment part is planned to be updated after GEM/ME0 merging.
GEMEfficiencyAnalyzer and GEMEfficiiencyHarvester measure GEM efficiency and resolution using both tight global muons and standalone muons.

PR validation:

This PR was tested with workflow 11611.0 and 27411.0.
Plots can be found in he following two links.
https://indico.cern.ch/event/927191/contributions/3898232/attachments/2053764/3443071/Talk_GEM_DPG_200609_Offline_DQM.pdf
https://indico.cern.ch/event/931844/contributions/3916126/attachments/2062310/3459906/GEM_DPG_200623_Offline_DQM.pdf

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30365/16422

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @seungjin-yang for master.

It involves the following packages:

DQMOffline/Muon

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @bellan, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @ptcox, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@seungjin-yang
Copy link
Contributor Author

New commits remove a deprecated gemEfficiencyHarvesterLoose from gemEfficiencyHarvesterSeq and unnecessary comments.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30365/16429

  • This PR adds an extra 32KB to repository

@seungjin-yang
Copy link
Contributor Author

@szaleski

@cmsbuild
Copy link
Contributor

Pull request #30365 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 1f805cd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da8bcb/7347/summary.html
CMSSW: CMSSW_11_2_X_2020-06-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da8bcb/7347/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778915
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778861
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1620.536 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 144.873 KiB GEM/GEMEfficiency
  • DQMHistoSizes: changed ( 11634.0,... ): 20.975 KiB GEM/GEMOfflineMonitor
  • DQMHistoSizes: changed ( 20034.0,... ): 218.818 KiB GEM/GEMEfficiency
  • DQMHistoSizes: changed ( 20034.0,... ): 38.949 KiB GEM/GEMOfflineMonitor
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1
Plots have very low (6 ) or null entries in the tested workflows but seem ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@davidlange6
Copy link
Contributor

looks like this created problems in the IB - should it be reverted before 1100?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants