edm::Range interface to TrackCandidate recHits

[guitargeek]

PR description:

A little follow-up to #29971, making the interface to the recHits of different classes more consistent and adapted for range-based loops. That makes also these overloaded functions in FakeTrackProducers unnecessary:

https://github.com/cms-sw/cmssw/pull/30361/files#diff-11165275dc0c3719761c168a2845339fL39

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backports intended.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30361/16403

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoEgamma/EgammaPhotonProducers/src/TrackProducerWithSCAssociation.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
  • File RecoTracker/DebugTools/plugins/TestHits.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File RecoTracker/DebugTools/plugins/TestSmoothHits.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File RecoTracker/FinalTrackSelectors/plugins/DuplicateListMerger.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File RecoTracker/FinalTrackSelectors/plugins/TrackCandidateTopBottomHitFilter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File RecoTracker/TrackProducer/interface/TrackProducerAlgorithm.icc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DQM/TrackingMonitor
DataFormats/TrackCandidate
RecoEgamma/EgammaPhotonProducers
RecoTracker/DebugTools
RecoTracker/FinalTrackSelectors
RecoTracker/TrackProducer

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @jainshilpi, @fioriNTU, @threus, @varuns23, @hdelanno, @makortel, @JanFSchulte, @lgray, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @jandrea, @mschrode, @idebruyn, @ebrondol, @mtosi, @dgulhan, @sobhatta, @lecriste, @afiqaize, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-24-1400/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7331/console Started: 2020/06/25 01:33

[cmsbuild]

+1
Tested at: ddeac05
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a31ea/7331/summary.html
CMSSW: CMSSW_11_2_X_2020-06-24-1400
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a31ea/7331/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778861
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

There seems to be Static Check errors in the test

[cmsbuild]

Pull request #30361 was updated. @perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-25-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7409/console Started: 2020/06/25 20:16

[cmsbuild]

+1
Tested at: 50ddaa3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a31ea/7409/summary.html
CMSSW: CMSSW_11_2_X_2020-06-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a31ea/7409/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778915
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778864
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[perrotta]

+1

• Similar to what was done in Better TrajectorySeed interface to recHits #29971, where a more user-friendly edm::Range interface was implemented for TrajectorySeed refHits, this PR extends such an interface to TrackCandidate recHits, and propagates its usage to the affected parts of the CMSSW code
• Jenkins tests pass and show no difference in outputs with the baseline, as expected

[silviodonato]

do you have any comments @andrius-k @jfernan2 @kmaeshima @fioriNTU @schneiml?

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1