-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding geometry scenarios D59 and D60 implementing ETL version 4 and 5 #30340
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
df1e818
1st commit. Scenario D57 implementing etl/v5 added
icosivi 17c1d63
v3/mtdStructureTopology.xml added. MTDTopologyMode modified.
icosivi 2675162
ETLDetId modified. 2 bits added to module and modType (both mask and…
icosivi 707b812
Modified EtlDetId.h
icosivi a7f13e1
Fixed DetId for etl v5
icosivi 7f2a9a3
Added scenario D59 (ETL v5). ETLDetId modified for backward compatibi…
icosivi 593ac79
adding cms-mtdD59-geometry.xml
icosivi dbab7a5
Added scenarios D59 (D58+etl_v4) and D60 (D58+etl_v5). Overlap and t…
icosivi 8bdcb36
Fixed constants in v4/etl.xml and v5/etl.xml
icosivi 0e905af
Code-format applied
icosivi 54e8e45
SimDigiDumper modified, adding ETL dump
icosivi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
Configuration/Geometry/python/GeometryExtended2026D59Reco_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Configuration.Geometry.GeometryExtended2026D59_cff import * | ||
|
||
# tracker | ||
from Geometry.CommonTopologies.globalTrackingGeometry_cfi import * | ||
from RecoTracker.GeometryESProducer.TrackerRecoGeometryESProducer_cfi import * | ||
from Geometry.TrackerGeometryBuilder.trackerParameters_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerTopology_cfi import * | ||
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import * | ||
trackerGeometry.applyAlignment = cms.bool(False) | ||
|
||
# calo | ||
from Geometry.CaloEventSetup.HGCalV9Topology_cfi import * | ||
from Geometry.HGCalGeometry.HGCalGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.HFNoseTopology_cfi import * | ||
from Geometry.ForwardGeometry.HFNoseGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.CaloTopology_cfi import * | ||
from Geometry.CaloEventSetup.CaloGeometryBuilder_cfi import * | ||
CaloGeometryBuilder = cms.ESProducer("CaloGeometryBuilder", | ||
SelectedCalos = cms.vstring("HCAL", | ||
"ZDC", | ||
"EcalBarrel", | ||
"TOWER", | ||
"HGCalEESensitive", | ||
"HGCalHESiliconSensitive", | ||
"HGCalHEScintillatorSensitive", | ||
"HGCalHFNoseSensitive", | ||
) | ||
) | ||
from Geometry.EcalAlgo.EcalBarrelGeometry_cfi import * | ||
from Geometry.HcalEventSetup.HcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerTopology_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import * | ||
from Geometry.HcalEventSetup.hcalTopologyIdeal_cfi import * | ||
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import * | ||
from Geometry.EcalMapping.EcalMapping_cfi import * | ||
from Geometry.EcalMapping.EcalMappingRecord_cfi import * | ||
|
||
# muon | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from RecoMuon.DetLayers.muonDetLayerGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.gemGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.me0Geometry_cfi import * | ||
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import * | ||
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import * | ||
|
||
# forward | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
|
||
# timing | ||
from RecoMTD.DetLayers.mtdDetLayerGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdParameters_cff import * | ||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cff import * | ||
from Geometry.MTDNumberingBuilder.mtdTopology_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.idealForDigiMTDGeometry_cff import * | ||
mtdGeometry.applyAlignment = cms.bool(False) | ||
|
17 changes: 17 additions & 0 deletions
17
Configuration/Geometry/python/GeometryExtended2026D59_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Geometry.CMSCommonData.cmsExtendedGeometry2026D59XML_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import * | ||
from SLHCUpgradeSimulations.Geometry.fakeConditions_phase2TkT14_cff import * | ||
from Geometry.EcalCommonData.ecalSimulationParameters_cff import * | ||
from Geometry.HcalCommonData.hcalDDDSimConstants_cff import * | ||
from Geometry.HGCalCommonData.hgcalParametersInitialization_cfi import * | ||
from Geometry.HGCalCommonData.hgcalNumberingInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseParametersInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseNumberingInitialization_cfi import * | ||
from Geometry.MuonNumbering.muonGeometryConstants_cff import * | ||
|
||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cff import * |
63 changes: 63 additions & 0 deletions
63
Configuration/Geometry/python/GeometryExtended2026D60Reco_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Configuration.Geometry.GeometryExtended2026D60_cff import * | ||
|
||
# tracker | ||
from Geometry.CommonTopologies.globalTrackingGeometry_cfi import * | ||
from RecoTracker.GeometryESProducer.TrackerRecoGeometryESProducer_cfi import * | ||
from Geometry.TrackerGeometryBuilder.trackerParameters_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerTopology_cfi import * | ||
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import * | ||
trackerGeometry.applyAlignment = cms.bool(False) | ||
|
||
# calo | ||
from Geometry.CaloEventSetup.HGCalV9Topology_cfi import * | ||
from Geometry.HGCalGeometry.HGCalGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.HFNoseTopology_cfi import * | ||
from Geometry.ForwardGeometry.HFNoseGeometryESProducer_cfi import * | ||
from Geometry.CaloEventSetup.CaloTopology_cfi import * | ||
from Geometry.CaloEventSetup.CaloGeometryBuilder_cfi import * | ||
CaloGeometryBuilder = cms.ESProducer("CaloGeometryBuilder", | ||
SelectedCalos = cms.vstring("HCAL", | ||
"ZDC", | ||
"EcalBarrel", | ||
"TOWER", | ||
"HGCalEESensitive", | ||
"HGCalHESiliconSensitive", | ||
"HGCalHEScintillatorSensitive", | ||
"HGCalHFNoseSensitive", | ||
) | ||
) | ||
from Geometry.EcalAlgo.EcalBarrelGeometry_cfi import * | ||
from Geometry.HcalEventSetup.HcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerTopology_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import * | ||
from Geometry.HcalEventSetup.hcalTopologyIdeal_cfi import * | ||
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import * | ||
from Geometry.EcalMapping.EcalMapping_cfi import * | ||
from Geometry.EcalMapping.EcalMappingRecord_cfi import * | ||
|
||
# muon | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from RecoMuon.DetLayers.muonDetLayerGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.gemGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.me0Geometry_cfi import * | ||
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import * | ||
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import * | ||
|
||
# forward | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
|
||
# timing | ||
from RecoMTD.DetLayers.mtdDetLayerGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdParameters_cff import * | ||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cff import * | ||
from Geometry.MTDNumberingBuilder.mtdTopology_cfi import * | ||
from Geometry.MTDGeometryBuilder.mtdGeometry_cfi import * | ||
from Geometry.MTDGeometryBuilder.idealForDigiMTDGeometry_cff import * | ||
mtdGeometry.applyAlignment = cms.bool(False) | ||
|
17 changes: 17 additions & 0 deletions
17
Configuration/Geometry/python/GeometryExtended2026D60_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2026Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Geometry.CMSCommonData.cmsExtendedGeometry2026D60XML_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cfi import * | ||
from SLHCUpgradeSimulations.Geometry.fakeConditions_phase2TkT14_cff import * | ||
from Geometry.EcalCommonData.ecalSimulationParameters_cff import * | ||
from Geometry.HcalCommonData.hcalDDDSimConstants_cff import * | ||
from Geometry.HGCalCommonData.hgcalParametersInitialization_cfi import * | ||
from Geometry.HGCalCommonData.hgcalNumberingInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseParametersInitialization_cfi import * | ||
from Geometry.ForwardCommonData.hfnoseNumberingInitialization_cfi import * | ||
from Geometry.MuonNumbering.muonGeometryConstants_cff import * | ||
|
||
from Geometry.MTDNumberingBuilder.mtdNumberingGeometry_cff import * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@icosivi @casarsa most likely the version here should be [-3], we want the conversion on older ClassVersion data. This would explain why everything looks ok while writing, but then it miserably fails after reading back data from file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while it looks ok reading data from previous versions...