-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added esConsumes to modules in L1Trigger/L1THGCal #30314
Conversation
The code-checks are being triggered in jenkins. |
The changes were done under my supervision. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30314/16288
|
A new Pull Request was created by @JamminJones for master. It involves the following packages: L1Trigger/L1THGCal @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@JamminJones I think you closed this PR accidentally |
@kpedro88 After I had submitted the pull request, I noticed that there were more modules that needed to be changed, and then I closed the pull request in anticipation of those changes. |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30314/16295
|
Pull request #30314 was updated. @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please check and sign again. |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
merge |
PR description:
added esConsumes to 2 modules
PR validation:
the code compiles