Store anode wire hits in ALCT (ACLUT-3) #30301

dildick · 2020-06-19T03:42:42Z

PR description:

This PR stores the anode wire hits in the ALCT data format, so one can do detailed studies of the performance of the ALCT algorithm for Run-3 or Phase-2 (e.g. displaced muons, close-by muons, hadronic showers,...). It also allows for new logic to be developed aimed at enhancing the ALCT position resolution for Phase-2.

The PR is similar to #29233, and builds on top of #30104 (which has yet to be merged).

PR validation:

Tested with WF 20434.0 and on 100 single muon gun events

cmsDriver.py Configuration/Generator/python/SingleMuPt10_pythia8_cfi.py \
--fileout file:step1.root --mc \
--eventcontent FEVTDEBUG --datatier GEN-SIM --conditions auto:phase1_2021_realistic \
--beamspot Run3RoundOptics25ns13TeVLowSigmaZ --step GEN,SIM --geometry DB:Extended \
--era Run3 --python_filename SingleMu_GEN_SIM.py --no_exec   -n 10

cmsDriver.py step2.py --filein file:step1.root --fileout file:step2.root --mc \
--eventcontent FEVTDEBUG --datatier GEN-SIM-DIGI-L1 --conditions auto:phase1_2021_realistic \
--step DIGI:pdigi_valid,L1 --geometry DB:Extended \
--era Run3 --python_filename step2_DIGI_L1.py --no_exec   -n 10

Somewhat verbose output of the simulation of a single pattern that ultimately produced an ALCT can be found below.

Finding pattern
Layer 1
	Wire 0, valid, wireN 93, OK in pattern
	Wire 1, valid, wireN 92, OK in pattern, HIT!
	Wire 2, valid, wireN 91, OK in pattern, HIT!
	Wire 3
	Wire 4
Layer 2
	Wire 0
	Wire 1, valid, wireN 92, OK in pattern
	Wire 2, valid, wireN 91, OK in pattern, HIT!
	Wire 3
	Wire 4
Layer 3
	Wire 0
	Wire 1
	Wire 2, valid, wireN 91, OK in pattern, HIT!
	Wire 3
	Wire 4
Layer 4
	Wire 0
	Wire 1
	Wire 2, valid, wireN 91, OK in pattern
	Wire 3, valid, wireN 90, OK in pattern, HIT!
	Wire 4
Layer 5
	Wire 0
	Wire 1
	Wire 2, valid, wireN 91, OK in pattern
	Wire 3, valid, wireN 90, OK in pattern, HIT!
	Wire 4, valid, wireN 89, OK in pattern, HIT!
Layer 6
	Wire 0
	Wire 1
	Wire 2, valid, wireN 91, OK in pattern
	Wire 3, valid, wireN 90, OK in pattern
	Wire 4, valid, wireN 89, OK in pattern, HIT!

Printing hits for keyWire 91 bx 8
Layer 1
	92	91
Layer 2
	91
Layer 3
	91
Layer 4
	90
Layer 5
	90	89
Layer 6
	89

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@tahuang1991

cmsbuild · 2020-06-19T03:43:09Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-19T03:50:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30301/16261

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCCommonTrigger/interface/CSCConstants.h modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104
- File L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104
- File L1Trigger/CSCTriggerPrimitives/interface/CSCCathodeLCTProcessor.h modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104, CLCT comparator code calculation (CCLUT-5) #30103
- File L1Trigger/CSCTriggerPrimitives/interface/CSCPatternBank.h modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104
- File L1Trigger/CSCTriggerPrimitives/plugins/CSCAnodeLCTAnalyzer.cc modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File L1Trigger/CSCTriggerPrimitives/src/CSCAnodeLCTProcessor.cc modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File L1Trigger/CSCTriggerPrimitives/src/CSCPatternBank.cc modified in PR(s): Rewrite ALCT trigger patterns as 2D vector (ACLUT-2) #30104

cmsbuild · 2020-06-19T03:51:12Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCCommonTrigger
L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @valuev this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

dildick · 2020-06-25T04:14:04Z

@rekovic Can you run the tests, please?

silviodonato · 2020-06-30T15:41:00Z

please test

cmsbuild · 2020-06-30T15:41:21Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-30-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7536/console Started: 2020/06/30 17:46

cmsbuild · 2020-06-30T17:08:16Z

+1
Tested at: 316ff47
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160efd/7536/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-30T17:08:19Z

Comparison job queued.

cmsbuild · 2020-06-30T19:01:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160efd/7536/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778915
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778864
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

silviodonato · 2020-07-06T10:39:23Z

@rekovic, can you please check and eventually sign?

rekovic · 2020-07-07T13:21:15Z

+1

cmsbuild · 2020-07-21T14:21:31Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-07-21-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8177/console Started: 2020/07/21 17:38

cmsbuild · 2020-07-21T16:42:22Z

+1
Tested at: 20851ca
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160efd/8177/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-07-21T16:42:25Z

Comparison job queued.

cmsbuild · 2020-07-21T18:57:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-160efd/8177/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2525996
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2525948
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

silviodonato · 2020-07-24T10:33:59Z

ping @rekovic

silviodonato · 2020-07-27T15:16:32Z

merge
@rekovic signed before the conflict #30301 (comment)

rekovic · 2020-07-28T05:04:34Z

+1

cmsbuild · 2020-07-28T05:04:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

davidlange6 · 2020-07-28T06:42:25Z

L1Trigger/CSCTriggerPrimitives/src/CSCAnodeLCTProcessor.cc

@@ -295,6 +295,11 @@ void CSCAnodeLCTProcessor::run(const std::vector<int> wire[CSCConstants::NUM_LAY
  // Take the best MAX_CLCTS_PER_PROCESSOR candidates per bx.
  int ALCTIndex_[CSCConstants::MAX_ALCT_TBINS] = {};

+  // define a new pattern map
+  // for each key half strip, and for each pattern, store the 2D collection of fired comparator digis
+  std::map<int, std::map<int, CSCCLCTDigi::ComparatorContainer>> hits_in_patterns;


so this is a map of a map of a vector of vectors?

@davidlange6 So the type needs to be corrected (#30940), but it shouldn't have any effect. ComparatorContainer and WireContainer are both 2D vectors.

Yes, it maps wiregroups and pattern numbers onto 2D vectors with hits.

dildick · 2020-07-28T12:23:04Z

Hold. Not sure how CSCCLCTDigi::ComparatorContainer got in CSCALCTProcessor. That needs to be fixed.

cmsbuild added this to the CMSSW_11_2_X milestone Jun 19, 2020

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending labels Jun 19, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 19, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 30, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 30, 2020

cmsbuild mentioned this pull request Jul 1, 2020

CLCT comparator code calculation (CCLUT-5) #30103

Merged

cmsbuild added fully-signed and removed l1-pending pending-signatures labels Jul 7, 2020

cmsbuild added tests-pending and removed tests-started labels Jul 21, 2020

cmsbuild added tests-started and removed tests-pending labels Jul 21, 2020

cmsbuild added tests-approved and removed tests-started labels Jul 21, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 21, 2020

cmsbuild mentioned this pull request Jul 24, 2020

Fix broken LCTs reported in HLT_L1SingleMu25 [11_2_X] #30909

Merged

cmsbuild added orp-approved and removed orp-pending labels Jul 27, 2020

cmsbuild merged commit cefb576 into cms-sw:master Jul 27, 2020

This was referenced Jul 27, 2020

Throw if dereference an unset edm::Handle #30928

Merged

Better GEM handling in CSCDigiToRaw #30925

Merged

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jul 28, 2020

davidlange6 reviewed Jul 28, 2020

View reviewed changes

dildick mentioned this pull request Jul 28, 2020

Correct a container type in ALCT processor #30940

Closed

dildick deleted the from-CMSSW_11_2_X_2020-06-18-1100-Store-anode-wire-hits-in-ALCT branch August 2, 2020 01:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Store anode wire hits in ALCT (ACLUT-3) #30301

Store anode wire hits in ALCT (ACLUT-3) #30301

dildick commented Jun 19, 2020 •

edited

Loading

cmsbuild commented Jun 19, 2020

cmsbuild commented Jun 19, 2020

cmsbuild commented Jun 19, 2020

dildick commented Jun 25, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

silviodonato commented Jul 6, 2020

rekovic commented Jul 7, 2020

cmsbuild commented Jul 21, 2020 •

edited

Loading

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 24, 2020

silviodonato commented Jul 27, 2020

rekovic commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

davidlange6 Jul 28, 2020

dildick Jul 28, 2020

dildick commented Jul 28, 2020

Store anode wire hits in ALCT (ACLUT-3) #30301

Store anode wire hits in ALCT (ACLUT-3) #30301

Conversation

dildick commented Jun 19, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 19, 2020

cmsbuild commented Jun 19, 2020

cmsbuild commented Jun 19, 2020

dildick commented Jun 25, 2020

silviodonato commented Jun 30, 2020

cmsbuild commented Jun 30, 2020 • edited Loading

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

cmsbuild commented Jun 30, 2020

silviodonato commented Jul 6, 2020

rekovic commented Jul 7, 2020

cmsbuild commented Jul 21, 2020 • edited Loading

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

cmsbuild commented Jul 21, 2020

silviodonato commented Jul 24, 2020

silviodonato commented Jul 27, 2020

rekovic commented Jul 28, 2020

cmsbuild commented Jul 28, 2020

davidlange6 Jul 28, 2020

Choose a reason for hiding this comment

dildick Jul 28, 2020

Choose a reason for hiding this comment

dildick commented Jul 28, 2020

dildick commented Jun 19, 2020 •

edited

Loading

cmsbuild commented Jun 30, 2020 •

edited

Loading

cmsbuild commented Jul 21, 2020 •

edited

Loading