Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run3-gem41 Update the RPC ESModule so that it can follow the ERA easily #30280

Merged
merged 7 commits into from
Jun 24, 2020
Merged

Run3-gem41 Update the RPC ESModule so that it can follow the ERA easily #30280

merged 7 commits into from
Jun 24, 2020

Conversation

bsunanda
Copy link
Contributor

PR description:

Update the RPC ESModule so that it can follow the ERA easily

PR validation:

Use standard runTheMatrix.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jun 17, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30280/16219

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/RPCGeometryBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1

Tested at: 82b746d

CMSSW: CMSSW_11_2_X_2020-06-17-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3fd48/7158/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:32:37 2020-date Wed Jun 17 22:23:59 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:29:19 2020-date Wed Jun 17 22:24:02 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:32:20 2020-date Wed Jun 17 22:24:07 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2018.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:32:00 2020-date Wed Jun 17 22:24:14 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:31:02 2020-date Wed Jun 17 22:24:15 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:29:55 2020-date Wed Jun 17 22:24:21 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:31:28 2020-date Wed Jun 17 22:24:29 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:30:53 2020-date Wed Jun 17 22:24:37 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:33:13 2020-date Wed Jun 17 22:27:57 2020 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-17-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Wed Jun 17 22:33:34 2020-date Wed Jun 17 22:29:11 2020 s - exit: 18688

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3fd48/7158/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@bsunanda
Copy link
Contributor Author

@ianna @cvuosalo @silviodonato There is an issue with HLTrigger/Configuration/test and I am planning to make a separate PR to sort this out. The failure happened also in the previous PR

@cmsbuild
Copy link
Contributor

Pull request #30280 was updated. @Martin-Grunewald, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @fwyzard can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild cmsbuild mentioned this pull request Jun 22, 2020
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 8ce8c6a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3fd48/7244/summary.html
CMSSW: CMSSW_11_2_X_2020-06-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3fd48/7244/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@bsunanda
Copy link
Contributor Author

@cvuosalo Validation for RPC works OK. The issues are with GEM and DT. I shall try to see the GEM issue later on

@bsunanda
Copy link
Contributor Author

@cvuosalo @Martin-Grunewald Can you please sign this PR now that the unit tests are OK

@bsunanda
Copy link
Contributor Author

@cvuosalo As far as I understand the situation which Martti raised is OK for this PR. We have been using the name of a cfi/cff different from the process name it defines. The file name and process names are explicitly used in a number of places. So that action has to be handled globally in some manner later on.

@cvuosalo
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3e445fe into cms-sw:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvuosalo cvuosalo cvuosalo left review comments

@kpedro88 kpedro88 kpedro88 left review comments

@Martin-Grunewald Martin-Grunewald Martin-Grunewald left review comments

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed geometry-approved hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.
8 participants
@bsunanda @cmsbuild @slomeo @kpedro88 @Martin-Grunewald @cvuosalo @silviodonato @makortel