-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified conditions to fix incorrect HLT JEC [11_1_X] #30267
Modified conditions to fix incorrect HLT JEC [11_1_X] #30267
Conversation
A new Pull Request was created by @christopheralanwest for CMSSW_11_1_X. It involves the following packages: Configuration/AlCa @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
backport #30221 |
test parameters |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a backport of PR #30221. The GT diffs are the same as in the PR to master.
Negative HLT jet energies have been reported in Run-3 samples. The problem has been traced to the fact that Run-3 GTs currently load the 2016 HLT JECs, while it should actually make use of the 2017 HLT JECs.
2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_design_v5/111X_mcRun3_2021_design_v6
2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_realistic_v5/111X_mcRun3_2021_realistic_v6
2021 cosmic (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021cosmics_realistic_deco_v5/111X_mcRun3_2021cosmics_realistic_deco_v6
2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2021_realistic_HI_v6/111X_mcRun3_2021_realistic_HI_v7
2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2023_realistic_v5/111X_mcRun3_2023_realistic_v6
2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/111X_mcRun3_2024_realistic_v5/111X_mcRun3_2024_realistic_v6
PR validation:
Tests were performed with a candidate GT to ensure that the fix behaves as expected.
See the following presentations for details:
https://indico.cern.ch/event/915728/contributions/3850261/subcontributions/305633/attachments/2045906/3431055/200527_jme_hltJECs.pdf
https://cernbox.cern.ch/index.php/s/L6Sxh48hsyhq2m0
In addition, a technical test is performed:
runTheMatrix.py -l limited,7.23,159.0,12834.0 --ibeos
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is a backport of #30221. It is needed because the HLT JEC conditions currently used in the Run-3 GTs are incorrect.