Delete some orphaned BuildFiles #30228

guitargeek · 2020-06-13T14:29:02Z

PR description:

Delete 3 BuildFiles which were actually not building any sources.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

cmsbuild · 2020-06-13T14:29:31Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-13T14:37:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30228/16107

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File FastSimulation/CTPPSFastTrackingProducer/plugins/CTPPSFastTrackingProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936

cmsbuild · 2020-06-13T14:37:32Z

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CondCore/ESSources
FastSimulation/CTPPSFastTrackingProducer
FastSimulation/L1CaloTriggerProducer
Utilities/ReleaseScripts

@smuzaffar, @ssekmen, @Dr15Jones, @lveldere, @makortel, @tlampen, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @tocheng, @sbein, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@matt-komm, @mmusich, @wddgit, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

pohsun · 2020-06-14T17:07:07Z

please test

cmsbuild · 2020-06-14T17:07:30Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-14-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7052/console Started: 2020/06/14 19:13

cmsbuild · 2020-06-14T18:24:12Z

+1
Tested at: 5a2e1d3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-303f4b/7052/summary.html
CMSSW: CMSSW_11_2_X_2020-06-14-0000
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-14T18:24:15Z

Comparison job queued.

cmsbuild · 2020-06-14T22:45:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-303f4b/7052/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

makortel · 2020-06-14T23:49:36Z

FastSimulation/CTPPSFastTrackingProducer/plugins/CTPPSFastTrackingProducer.cc

+private:
+  void beginStream(edm::StreamID) override;
+  void produce(edm::Event&, const edm::EventSetup&) override;
+  void endStream() override;


This probably goes beyond this PR, but beginStream() and endStream() are empty and thus could be removed.

makortel · 2020-06-14T23:51:44Z

FastSimulation/CTPPSFastTrackingProducer/plugins/CTPPSFastTrackingProducer.cc

+  void endStream() override;
+  //this function will only be called once per event
+  virtual void beginEvent(edm::Event& event, const edm::EventSetup& eventSetup);
+  virtual void endEvent(edm::Event& event, const edm::EventSetup& eventSetup);


Again probably going beyond this PR, but what is the purpose of these functions? As far as I can tell, they are not called.

You are right, thanks! I removed them.

makortel · 2020-06-14T23:52:17Z

Utilities/ReleaseScripts/scripts/git-publish

@@ -455,7 +455,7 @@ CMSSW_CATEGORIES={"Operations": ["Configuration/Applications",
  "FastSimulation/Configuration", "FastSimulation/EgammaElectronAlgos",
  "FastSimulation/Event", "FastSimulation/EventProducer",
  "FastSimulation/ForwardDetectors", "FastSimulation/HighLevelTrigger",
-  "FastSimulation/L1CaloTriggerProducer", "FastSimulation/MaterialEffects",
+  "FastSimulation/MaterialEffects",


@smuzaffar Could you confirm this is OK given that FastSimulation/L1CaloTriggerProducer package is removed?

Yes this is fine

cmsbuild · 2020-06-16T00:10:29Z

Comparison job queued.

cmsbuild · 2020-06-16T01:55:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-303f4b/7090/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778757
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

makortel · 2020-06-16T12:59:03Z

+core

pohsun · 2020-06-17T04:34:48Z

+1

civanch · 2020-06-17T18:49:38Z

@jan-kaspar , @fabferro , are you OK with this PR?

fabferro · 2020-06-18T09:02:11Z

@jan-kaspar , @fabferro , are you OK with this PR?

I have nothing against but I would like the confirmation of @mundim that last modified these files within PPS group. @mundim: do you agree with this PR?

silviodonato · 2020-06-18T17:21:58Z

Do you have any objections @ggovi ?

mundim · 2020-06-18T17:45:37Z

@jan-kaspar , @fabferro , are you OK with this PR?

I have nothing against but I would like the confirmation of @mundim that last modified these files within PPS group. @mundim: do you agree with this PR?

I was not sure about FastSimulation/CTPPSFastTrackingProducer, if this would cause any problem to the PPS fast simulation, but I just found out that (likely) no one is using it. So, I guess you can go on.

civanch · 2020-06-19T08:34:02Z

+1

ggovi · 2020-06-23T11:32:51Z

+1

cmsbuild · 2020-06-23T11:33:15Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-06-23T16:38:57Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jun 13, 2020

cmsbuild added alca-pending code-checks-pending comparison-pending core-pending db-pending fastsim-pending orp-pending pending-signatures tests-pending labels Jun 13, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 13, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 14, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 14, 2020

makortel reviewed Jun 14, 2020

View reviewed changes

some buildfile related fixups

55963f8

cmsbuild removed code-checks-approved comparison-available labels Jun 15, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 16, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 16, 2020

cmsbuild added core-approved and removed core-pending labels Jun 16, 2020

cmsbuild added alca-approved and removed alca-pending labels Jun 17, 2020

cmsbuild added fastsim-approved and removed fastsim-pending labels Jun 19, 2020

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jun 23, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 23, 2020

cmsbuild merged commit 86a9f8e into cms-sw:master Jun 23, 2020

guitargeek deleted the fixes_1 branch June 23, 2020 18:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete some orphaned BuildFiles #30228

Delete some orphaned BuildFiles #30228

guitargeek commented Jun 13, 2020

cmsbuild commented Jun 13, 2020

cmsbuild commented Jun 13, 2020

cmsbuild commented Jun 13, 2020

pohsun commented Jun 14, 2020

cmsbuild commented Jun 14, 2020 •

edited

Loading

cmsbuild commented Jun 14, 2020

cmsbuild commented Jun 14, 2020

cmsbuild commented Jun 14, 2020

makortel Jun 14, 2020

guitargeek Jun 15, 2020

makortel Jun 14, 2020

guitargeek Jun 15, 2020

makortel Jun 14, 2020

smuzaffar Jun 15, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

makortel commented Jun 16, 2020

pohsun commented Jun 17, 2020

civanch commented Jun 17, 2020

fabferro commented Jun 18, 2020

silviodonato commented Jun 18, 2020

mundim commented Jun 18, 2020

civanch commented Jun 19, 2020

ggovi commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

Delete some orphaned BuildFiles #30228

Delete some orphaned BuildFiles #30228

Conversation

guitargeek commented Jun 13, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 13, 2020

cmsbuild commented Jun 13, 2020

cmsbuild commented Jun 13, 2020

pohsun commented Jun 14, 2020

cmsbuild commented Jun 14, 2020 • edited Loading

cmsbuild commented Jun 14, 2020

cmsbuild commented Jun 14, 2020

cmsbuild commented Jun 14, 2020

makortel Jun 14, 2020

Choose a reason for hiding this comment

guitargeek Jun 15, 2020

Choose a reason for hiding this comment

makortel Jun 14, 2020

Choose a reason for hiding this comment

guitargeek Jun 15, 2020

Choose a reason for hiding this comment

makortel Jun 14, 2020

Choose a reason for hiding this comment

smuzaffar Jun 15, 2020

Choose a reason for hiding this comment

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

makortel commented Jun 16, 2020

pohsun commented Jun 17, 2020

civanch commented Jun 17, 2020

fabferro commented Jun 18, 2020

silviodonato commented Jun 18, 2020

mundim commented Jun 18, 2020

civanch commented Jun 19, 2020

ggovi commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

silviodonato commented Jun 23, 2020

cmsbuild commented Jun 14, 2020 •

edited

Loading