Remove CondFormats from DataFormats

[davidlange6]

Minimal move of some enums out of CondFormats/L1TObjects into DataFormats. Removes the incorrect dependency of DataFormats on CondFormats.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30198/16037

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30198/16037/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30198/16037/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30198/16038

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CondFormats/L1TObjects
DataFormats/L1GlobalTrigger
DataFormats/PatCandidates
PhysicsTools/NanoAOD

@perrotta, @benkrikler, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @fgolf, @tlampen, @ggovi, @pohsun, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gouskos, @cbernet, @rovere, @tocheng, @hatakeyamak, @gpetruc, @mmusich, @peruzzim, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test On Jun 11, 2020, at 5:35 PM, cmsbuild <[email protected]<mailto:[email protected]>> wrote: A new Pull Request was created by @davidlange6<https://github.com/davidlange6> (David Lange) for master. It involves the following packages: CondFormats/L1TObjects DataFormats/L1GlobalTrigger DataFormats/PatCandidates PhysicsTools/NanoAOD @perrotta<https://github.com/perrotta>, @benkrikler<https://github.com/benkrikler>, @slava77<https://github.com/slava77>, @christopheralanwest<https://github.com/christopheralanwest>, @tocheng<https://github.com/tocheng>, @cmsbuild<https://github.com/cmsbuild>, @rekovic<https://github.com/rekovic>, @fgolf<https://github.com/fgolf>, @tlampen<https://github.com/tlampen>, @ggovi<https://github.com/ggovi>, @pohsun<https://github.com/pohsun>, @santocch<https://github.com/santocch>, @peruzzim<https://github.com/peruzzim> can you please review it and eventually sign? Thanks. @gouskos<https://github.com/gouskos>, @cbernet<https://github.com/cbernet>, @rovere<https://github.com/rovere>, @tocheng<https://github.com/tocheng>, @hatakeyamak<https://github.com/hatakeyamak>, @gpetruc<https://github.com/gpetruc>, @mmusich<https://github.com/mmusich>, @peruzzim<https://github.com/peruzzim>, @seemasharmafnal<https://github.com/seemasharmafnal> this is something you requested to watch as well. @silviodonato<https://github.com/silviodonato>, @dpiparo<https://github.com/dpiparo> you are the release manager for this. cms-bot commands are listed here<http://cms-sw.github.io/cms-bot-cmssw-cmds.html> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#30198 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ6R77AOUKHRSTYSUFLRWD2SXANCNFSM4N3QKQ2A>.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6967/console Started: 2020/06/11 17:47

[cmsbuild]

+1
Tested at: f8d2412
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac7da3/6967/summary.html
CMSSW: CMSSW_11_2_X_2020-06-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac7da3/6967/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2779433
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2779382
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[perrotta]

+1

• Technical
• jenkins tests pass

[pohsun]

+1

[santocch]

+1

[silviodonato]

do you have any comments @rekovic @peruzzim @ggovi ?

[ggovi]

+1

[davidlange6]

@silviodonato - can we move forward in the next days if no further input is expected?

[silviodonato]

merge
@rekovic @peruzzim