Modernized GenTtbarCategorizer

[Dr15Jones]

PR description:

• converted to edm::global::EDProducer
• filled in fillDescriptions

PR validation:

Code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30150/15935

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File TopQuarkAnalysis/TopTools/plugins/GenTtbarCategorizer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-emplace #29937

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

TopQuarkAnalysis/TopTools

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

This fixes the step5 case in #25090

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6883/console Started: 2020/06/08 17:33

[cmsbuild]

+1
Tested at: 3dcddd7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e46ef4/6883/summary.html
CMSSW: CMSSW_11_2_X_2020-06-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e46ef4/6883/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780497
• DQMHistoTests: Total failures: 46
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780401
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1
@Dr15Jones for my education, should we also remove the _cfi.py file https://github.com/cms-sw/cmssw/blob/master/TopQuarkAnalysis/TopTools/python/GenTtbarCategorizer_cfi.py ?

[Dr15Jones]

@silviodonato

for my education, should we also remove the _cfi.py file https://github.com/cms-sw/cmssw/blob/master/TopQuarkAnalysis/TopTools/python/GenTtbarCategorizer_cfi.py ?

I think that would be best, yes.

[silviodonato]

Ok, I created #30193