-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove invalid usage of TrajectorySeed::recHits() #30133
Remove invalid usage of TrajectorySeed::recHits() #30133
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30133/15915
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoEgamma/EgammaPhotonAlgos @perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+dqm |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is sort of a followup to #29971, in which I spotted some undefined behaviour in code that uses the
TrajectorySeed::recHits()
. Theend()
iterator is dereferenced in there, which gives garbage results.Rather than trying to fix this, I suggest to just remove the problematic code. It is unused and probably not important, otherwise the bug would have been found before. Do you agree with this procedure?
I hope I understood this correctly that there is a bug, otherwise please correct me.
PR validation:
CMSSW compiles and matrix tests pass.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.