Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid usage of TrajectorySeed::recHits() #30133

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Remove invalid usage of TrajectorySeed::recHits() #30133

merged 1 commit into from
Jun 25, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

This is sort of a followup to #29971, in which I spotted some undefined behaviour in code that uses the TrajectorySeed::recHits(). The end() iterator is dereferenced in there, which gives garbage results.

Rather than trying to fix this, I suggest to just remove the problematic code. It is unused and probably not important, otherwise the bug would have been found before. Do you agree with this procedure?

I hope I understood this correctly that there is a bug, otherwise please correct me.

PR validation:

CMSSW compiles and matrix tests pass.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30133/15915

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEgamma/EgammaPhotonAlgos
RecoMuon/TrackerSeedGenerator
RecoTracker/MeasurementDet
Validation/RecoMuon

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @jainshilpi, @abbiendi, @echapon, @varuns23, @cericeci, @makortel, @jhgoh, @lgray, @HuguesBrun, @trocino, @rociovilar, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @mschrode, @ebrondol, @dgulhan, @Fedespring, @calderona, @sobhatta, @afiqaize, @gpetruc, @folguera this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6860/console Started: 2020/06/07 13:51

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

+1
Tested at: 38b49a2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-604ec5/6860/summary.html
CMSSW: CMSSW_11_2_X_2020-06-06-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-604ec5/6860/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780497
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780407
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 7, 2020

+dqm

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 38b49a2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-604ec5/7135/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-604ec5/7135/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 24, 2020

+1

  • Removal of unused parts of code, and restructurations of other ones
  • Jenkins tests pass and show no differences in reco outputs, or anywhere else
  • Timing also not affected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0be0752 into cms-sw:master Jun 25, 2020
@guitargeek guitargeek deleted the TrajectorySeed_recHits_followup branch June 26, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants