-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.1.X [Tracker Alignment] All-in-one tool support of multiple tags in user-inputed sqlite file #30078
11.1.X [Tracker Alignment] All-in-one tool support of multiple tags in user-inputed sqlite file #30078
Conversation
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X. It involves the following packages: Alignment/OfflineValidation @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged. |
backport of #30077
PR description:
In this commit: ca150f3 we introduced a new method in order to read local sqlite files in the tracker alignment all-in-one tool, by using
conddblib
to check contents of sqlite files.In the original implementation in PR #29339 I did not foresee to put more than one tag into a local sqlite file, but this appears to be a required use case.
The issue and the fix have been provided by @adewit.
I profit of this PR also to update the unit test to cover this use-case.
PR validation:
Relies on the existing unit test in the subsystem. I have tested this in
CMSSW_11_1_X_2020-06-02-1100
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is a verbatim backport of #30077