optimize some hotspot use cases of deltaR and polar in reco/miniAOD (backport of #29918 )

[slava77]

backport of #29918

Technical improvements to reduce time in calls to deltaR where polar Lorentz vectors can be used or where (eta,phi) are available directly.
Here the expected gain is mainly limited to miniIsolation and isolatedTracks.
In a 2016 re-miniAOD workflow 136.7611 times per event in relevant modules are reduced significantly for a total of about 4% of the re-miniAOD step:

2.32 ms/ev ->         0.81 ms/ev patElectrons
115.03 ms/ev ->        51.91 ms/ev isolatedTracks
21.10 ms/ev ->         9.67 ms/ev patMuons

no changes are expected based on #29918

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_6_X.

It involves the following packages:

CommonTools/CandAlgos
PhysicsTools/PatAlgos
PhysicsTools/PatUtils
RecoMET/METAlgorithms

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @JyothsnaKomaragiri, @makortel, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @ahinzmann, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

• Backported from optimize some hotspot use cases of deltaR and polar in reco/miniAOD #29918

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6449/console Started: 2020/05/20 06:37

[cmsbuild]

+1
Tested at: 89e72b5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a5455/6449/summary.html
CMSSW: CMSSW_10_6_X_2020-05-19-2300
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[santocch]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a5455/6449/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211989
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[slava77]

+1

for #29919 89e72b5

• jenkins tests passed confirming no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1